Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make YoutubeJavaScriptExtractor more robust #693

Closed
XiangRongLin opened this issue Jul 28, 2021 · 0 comments · Fixed by #694
Closed

Make YoutubeJavaScriptExtractor more robust #693

XiangRongLin opened this issue Jul 28, 2021 · 0 comments · Fixed by #694
Labels
bug Issue is related to a bug youtube service, https://www.youtube.com/

Comments

@XiangRongLin
Copy link
Collaborator

XiangRongLin commented Jul 28, 2021 •
edited
Loading

YoutubeJavaScriptExtractor currently sometimes failes to find the javascript file , which contains the multiple decryption functions.
See TODO in file

NewPipeExtractor/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeJavaScriptExtractor.java

Line 74 in 14c179f

// playerJsUrl is still available in the file, just somewhere else TODO

see crash TeamNewPipe/NewPipe#6780
@XiangRongLin XiangRongLin added bug Issue is related to a bug youtube service, https://www.youtube.com/ labels Jul 28, 2021
@litetex litetex mentioned this issue Jul 28, 2021
Merged
3 tasks
@FireMasterK FireMasterK mentioned this issue Jul 28, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue is related to a bug youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Faster iframe api based player extraction. FireMasterK/NewPipeExtractor
1 participant
@XiangRongLin