Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PeerTube] Error when a comment is deleted #339

Closed
B0pol opened this issue May 30, 2020 · 2 comments · Fixed by #340
Closed

[PeerTube] Error when a comment is deleted #339

B0pol opened this issue May 30, 2020 · 2 comments · Fixed by #340
Labels
bug Issue is related to a bug peertube service, https://joinpeertube.org/

Comments

@B0pol
Copy link
Member

B0pol commented May 30, 2020 •
edited
Loading

Exception

  • User Action: requested comments
  • Request: I don't want to share the url
  • Content Language: fr_FR
  • Service: PeerTube
  • Version: 0.19.4
  • OS: Linux Android 9 - 28
Crash log

org.schabi.newpipe.extractor.exceptions.ParsingException: Unable to get account.displayName
	at org.schabi.newpipe.extractor.utils.JsonUtils.getValue(JsonUtils.java:28)
	at org.schabi.newpipe.extractor.utils.JsonUtils.getString(JsonUtils.java:34)
	at org.schabi.newpipe.extractor.services.peertube.extractors.PeertubeCommentsInfoItemExtractor.getName(PeertubeCommentsInfoItemExtractor.java:44)
	at org.schabi.newpipe.extractor.comments.CommentsInfoItemsCollector.extract(CommentsInfoItemsCollector.java:22)
	at org.schabi.newpipe.extractor.comments.CommentsInfoItemsCollector.commit(CommentsInfoItemsCollector.java:79)
	at org.schabi.newpipe.extractor.services.peertube.extractors.PeertubeCommentsExtractor.collectStreamsFrom(PeertubeCommentsExtractor.java:53)
	at org.schabi.newpipe.extractor.services.peertube.extractors.PeertubeCommentsExtractor.getPage(PeertubeCommentsExtractor.java:81)
	at org.schabi.newpipe.extractor.services.peertube.extractors.PeertubeCommentsExtractor.onFetchPage(PeertubeCommentsExtractor.java:90)
	at org.schabi.newpipe.extractor.Extractor.fetchPage(Extractor.java:56)
	at org.schabi.newpipe.extractor.comments.CommentsInfo.getInfo(CommentsInfo.java:33)
	at org.schabi.newpipe.extractor.comments.CommentsInfo.getInfo(CommentsInfo.java:24)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getCommentsInfo$7(ExtractorHelper.java:155)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$Xyj84g1UeNZqX9LVYNvWZsdT-kI.call(Unknown Source:4)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3666)
	at io.reactivex.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
	at io.reactivex.Single.subscribe(Single.java:3666)
	at io.reactivex.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
	at io.reactivex.Maybe.subscribe(Maybe.java:4290)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42)
	at io.reactivex.Flowable.subscribe(Flowable.java:14935)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36)
	at io.reactivex.Maybe.subscribe(Maybe.java:4290)
	at io.reactivex.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46)
	at io.reactivex.Single.subscribe(Single.java:3666)
	at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:764)

-------------------

org.schabi.newpipe.extractor.exceptions.ParsingException: Unable to get account.displayName
	at org.schabi.newpipe.extractor.utils.JsonUtils.getValue(JsonUtils.java:28)
	at org.schabi.newpipe.extractor.utils.JsonUtils.getString(JsonUtils.java:34)
	at org.schabi.newpipe.extractor.services.peertube.extractors.PeertubeCommentsInfoItemExtractor.getName(PeertubeCommentsInfoItemExtractor.java:44)
	at org.schabi.newpipe.extractor.comments.CommentsInfoItemsCollector.extract(CommentsInfoItemsCollector.java:22)
	at org.schabi.newpipe.extractor.comments.CommentsInfoItemsCollector.commit(CommentsInfoItemsCollector.java:79)
	at org.schabi.newpipe.extractor.services.peertube.extractors.PeertubeCommentsExtractor.collectStreamsFrom(PeertubeCommentsExtractor.java:53)
	at org.schabi.newpipe.extractor.services.peertube.extractors.PeertubeCommentsExtractor.getPage(PeertubeCommentsExtractor.java:81)
	at org.schabi.newpipe.extractor.services.peertube.extractors.PeertubeCommentsExtractor.onFetchPage(PeertubeCommentsExtractor.java:90)
	at org.schabi.newpipe.extractor.Extractor.fetchPage(Extractor.java:56)
	at org.schabi.newpipe.extractor.comments.CommentsInfo.getInfo(CommentsInfo.java:33)
	at org.schabi.newpipe.extractor.comments.CommentsInfo.getInfo(CommentsInfo.java:24)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getCommentsInfo$7(ExtractorHelper.java:155)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$Xyj84g1UeNZqX9LVYNvWZsdT-kI.call(Unknown Source:4)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3666)
	at io.reactivex.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
	at io.reactivex.Single.subscribe(Single.java:3666)
	at io.reactivex.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
	at io.reactivex.Maybe.subscribe(Maybe.java:4290)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42)
	at io.reactivex.Flowable.subscribe(Flowable.java:14935)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36)
	at io.reactivex.Maybe.subscribe(Maybe.java:4290)
	at io.reactivex.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46)
	at io.reactivex.Single.subscribe(Single.java:3666)
	at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:764)

There were 2 deleted comments hence the two crash in crash report

There is a field isDeleted in json response. We should handle it.
@B0pol B0pol added peertube service, https://joinpeertube.org/ bug Issue is related to a bug labels May 30, 2020
@wb9688
Copy link
Contributor

wb9688 commented May 30, 2020 •
edited
Loading

I'll fix this tomorrow, unless you come with a PR first

@B0pol
Copy link
Member Author

B0pol commented May 31, 2020

I let you do it

@wb9688 wb9688 mentioned this issue May 31, 2020
Merged
3 tasks
@B0pol B0pol mentioned this issue Jul 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue is related to a bug peertube service, https://joinpeertube.org/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle isDeleted for PeerTube comments
2 participants
@wb9688 @B0pol