Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue: App crashes and stop the video on rotation while playing the video. #9705

Closed
6 tasks done
giwrgosmant opened this issue Jan 19, 2023 · 8 comments
Closed
6 tasks done

Issue: App crashes and stop the video on rotation while playing the video. #9705

giwrgosmant opened this issue Jan 19, 2023 · 8 comments
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)

Comments

@giwrgosmant
Copy link
Contributor

giwrgosmant commented Jan 19, 2023 •
edited
Loading

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.24.1

Steps to reproduce the bug

  1. Play one video.
  2. Rotate your phone horizontally.
  3. Rotate your phone again vertically.
  4. The app crashes and it stops the video.

Expected behavior

To rotate without an error and without stopping the video.

Actual behavior

It crashes and it stops the video.

Screenshots/Screen recordings

I don't remember from which version it started to happen, it been here for a while.
You can check the video I recorded at MEGA Cloud.

Logs

Logs - NewPipe - Rotation Issue.txt
Exception

  • User Action: play stream
  • Request: Player error[type=ERROR_CODE_FAILED_RUNTIME_CHECK] occurred while playing https://www.youtube.com/watch?v=jvpGKLJAvs0
  • Content Country: GR
  • Content Language: el-GR
  • App Language: el_GR
  • Service: YouTube
  • Version: 0.24.1
  • OS: Linux Android 13 - 33
Crash log 

com.google.android.exoplayer2.ExoPlaybackException: Unexpected runtime error
	at com.google.android.exoplayer2.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:616)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.os.HandlerThread.run(HandlerThread.java:67)
Caused by: java.lang.IllegalArgumentException
	at android.media.MediaCodec.native_setSurface(Native Method)
	at android.media.MediaCodec.setOutputSurface(MediaCodec.java:2234)
	at com.google.android.exoplayer2.mediacodec.AsynchronousMediaCodecAdapter$$ExternalSyntheticApiModelOutline0.m(Unknown Source:0)
	at com.google.android.exoplayer2.mediacodec.AsynchronousMediaCodecAdapter.setOutputSurface(AsynchronousMediaCodecAdapter.java:262)
	at com.google.android.exoplayer2.video.MediaCodecVideoRenderer.setOutputSurfaceV23(MediaCodecVideoRenderer.java:1451)
	at com.google.android.exoplayer2.video.MediaCodecVideoRenderer.setOutput(MediaCodecVideoRenderer.java:646)
	at com.google.android.exoplayer2.video.MediaCodecVideoRenderer.handleMessage(MediaCodecVideoRenderer.java:584)
	at com.google.android.exoplayer2.ExoPlayerImplInternal.deliverMessage(ExoPlayerImplInternal.java:1546)
	at com.google.android.exoplayer2.ExoPlayerImplInternal.sendMessageToTarget(ExoPlayerImplInternal.java:1510)
	at com.google.android.exoplayer2.ExoPlayerImplInternal.sendMessageInternal(ExoPlayerImplInternal.java:1485)
	at com.google.android.exoplayer2.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:521)
	... 4 more

Affected Android/Custom ROM version

Androi 13 / crDroid 9.1 ROM

Affected device model

POCO F1

Additional information

No response
@giwrgosmant giwrgosmant added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Jan 19, 2023
@AudricV
Copy link
Member

AudricV commented Jan 19, 2023

Issue: App crashes and stop the video on rotation while playing the video.

Issue: you didn't follow the template instructions.

Please search (better, with different keywords?) for duplicates, especially pinned posts, the next time you want to open an issue. Thank you.

@AudricV AudricV closed this as completed Jan 19, 2023
@AudricV AudricV added template ignored The user didn't follow the template/instructions (or removed them) duplicate Issue or discussion is a duplicate of an existing issue or discussion and removed bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Jan 19, 2023
@giwrgosmant
Copy link
Contributor Author

giwrgosmant commented Jan 19, 2023 •
edited
Loading

Issue: App crashes and stop the video on rotation while playing the video.

Issue: you didn't follow the template instructions.

Please search (better, with different keywords?) for duplicates, especially pinned posts, the next time you want to open an issue. Thank you.

First of all I would appreciate if your reply could be less with irony and provide much more information, I guess with the link of the duplicate? Since I think I help a lot with translation of the app to my native language by spent much time and I just opened this issue since it's been a while without fix after couple of updates.

I searched the words "rotation" and "rotate " since this is what I encounter. I don't have time to do maths and matches with different words to find if this issue exist, and if exist you should change the title of the issue to be better recognizable.

The pinned post you mentioned, describe an issue with "Fullscreen" and "Android TV". This is not what I encounter. My issue is after I exit fullscreen with rotation.
Other issues I found was "while loading video" or "if other video is on queue" and other things.

Thanks.

@giwrgosmant
Copy link
Contributor Author

@AudricV so you will point me the link of duplicate please to check it out?

@opusforlife2
Copy link
Collaborator

@giwrgosmant crDroid is a known problematic OS. Whenever you encounter a bug on it, try another OS first.

@ghost
Copy link

ghost commented Mar 18, 2023 •
edited by ghost
Loading

Might be duplicate of #9277 or #9329 & #9023

@giwrgosmant
Copy link
Contributor Author

giwrgosmant commented Mar 18, 2023 •
edited
Loading

Might be duplicate of #9277 or #9329

Nah the first issue is if you que 2 or more videos and the second if you enter full screen mode. None of these was my issue. As I said, I searched before I post my issue but they closed it before they look at it properly or at all...

Anyways...the issue was probably related to crDroid, seems fixed and mentioned at Changelog of 12 March 2023: - Fixed a possible crash of players using ExoPlayer when rotating phone from landscape to portrait

@opusforlife2
Copy link
Collaborator

seems fixed

It would be great if you could confirm this for us. We often get crDroid issues here.

@giwrgosmant
Copy link
Contributor Author

giwrgosmant commented Mar 18, 2023 •
edited
Loading

seems fixed

It would be great if you could confirm this for us. We often get crDroid issues here.

My issue is fixed with the latest update of crDroid with the fix of ExoPlayer mentioned above. I can confirm.
Here is the full changelog of crDroid for my device and general:

Highlights & Device Specific Changes:
Build type: Weekly
Device: Pocophone F1 (beryllium)
Device maintainer: Lup Gabriel (gwolfu)

===== 12 March, 2023 =====

  • crDroid-Settings: Use SystemSettingListPreference for status bar logo style
  • Added "Linux" logos icons for status bar
  • Add CookieRun Font
  • Add back button for freeform window
  • SystemUI: Implement Bluetooth dialog
  • SystemUI: Prevent systemui crash when reinflating QS
  • SystemUI: add haptic feedback for qs tiles
  • SystemUI: Refactor notification reticker
  • Settings: Update AppLock API
  • Launcher3: Add a preference to manually restart the launcher
  • Launcher3: Update AppLock API and integrate hidden apps
  • Launcher3: Restore blur depth on configuration change
  • Launcher3: Improve CustomSeekBarPreference drawables
  • Allow enabling ethernet tethering independent of link state
  • Fixed Youtube application animation when moving to PIP
  • Fixed a possible crash of players using ExoPlayer when rotating phone from landscape to portrait
  • Some other PIP fixes
  • Less boring heads up: Don't skip heads up for most messaging apps
  • Aperture updates
  • Updated themed icons
  • Updated art and bionic
  • Updated translations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@giwrgosmant @opusforlife2 @AudricV