Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make channel group card size customizable #9387

Open
6 tasks done
simpleavinash opened this issue Nov 12, 2022 · 14 comments
Open
6 tasks done

Make channel group card size customizable #9387

simpleavinash opened this issue Nov 12, 2022 · 14 comments
Labels
channel group Anything to do with channel groups in the app feature request Issue is related to a feature in the app

Comments

@simpleavinash
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

I'm fan of the classis horizontal scrolling (v24.0).

Why do you want this feature?

Make channel group card size customizable. It only fits 3 cards. I want to revert back this particular channel group list view feature. Please solve this.

Additional information

Feedback for v24.1 on Channel group

Dear Sir, UI or layout modifications can't be welcomed by everybody. I've been using NewPipe for years and I've become habitual to the classic layout. If you make modifications in layout, please make it optional in settings. I personally don't like this new vertical scrolling layout (List and Big card view) of channel groups, it irritates me everytime I use this feature, 10 times in a day at least.

Please make this mod optional in settings, so whoever like it will turn it ON and many like me will keep it Off. In my opinion, UI modification shouldn't be mandatory to all, only Feature or functionality should.

Thank you, Rest is perfect. 👍
(I made github account only due to this inconvenience).

@simpleavinash simpleavinash added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Nov 12, 2022
@SameenAhnaf
Copy link
Collaborator

What do you think about solution mentioned in #6372 (comment)?

If you are ok that, I'll close this issue.

@SameenAhnaf SameenAhnaf added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Nov 12, 2022
@opusforlife2
Copy link
Collaborator

The layout follows your list/grid setting. If you toggle that to grid, you'll get the old layout.

@SameenAhnaf
Copy link
Collaborator

@opusforlife2 That still seems to be problematic for the user. Moreover, channel group view doesn't stay remembered. If you choose list view mode overall but grid for channel groups, app will revert back to list view completely on restart.

Make channel group card size customizable. It only fits 3 cards.

I personally don't like this new vertical scrolling layout (List and Big card view) of channel groups, it irritates me everytime I use this feature, 10 times in a day at least.

@opusforlife2
Copy link
Collaborator

This (along with Downloads) is the only place where the list/grid toggle has been provided separately. We could make a decision on whether manually changed layouts should stop following the setting, or whether there should be toggles for the layout at all, instead of enforcing the setting everywhere.

Conversely, why should there be a list/grid setting at all, even? All views could be independently toggle-able between list and grid, and the state could be saved for each such view independent of the others.

@simpleavinash
Copy link
Author

simpleavinash commented Nov 12, 2022

Dear all, Thank you for paying attention to my request.

A. This version24 layout (classic or legacy style) is my first choice. Can you please keep this layout continue to next versions. And keep this (Horizontal scrolling) style also in settings for those who like it, and make it optional to choose the new version24.1 list view.

A

B. If you have to change the channel group to list view, and want to remove the classic group style, then please make an option to customize the size of cards. I want to fit more than 3 (say 6 or 8) cards here.

B

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Nov 12, 2022
@simpleavinash
Copy link
Author

simpleavinash commented Nov 12, 2022

I'm currently using this https://github.com/TeamNewPipe/NewPipe/files/9942509/app-debug4.zip app from (#9182), than new official v24.1 release, Due to new channel group list layout.

My point is, I want to stick to the old card layout.

@SameenAhnaf

This comment was marked as outdated.

@simpleavinash
Copy link
Author

simpleavinash commented Nov 12, 2022

The layout follows your list/grid setting. If you toggle that to grid, you'll get the old layout.

Dear sir,
Old cards had smaller size, while new cards are very big.

@simpleavinash
Copy link
Author

simpleavinash commented Nov 12, 2022

Thanks for your feedback. What do you think about vertical scrolling? These three rows will remain static instead of one row as in case of horizontal scrolling. It'll also require less scrolling compared to classic one.

119712128-9f825e80-bea3-11eb-89e9-01b77e9ed459

Dear sir,
Well this is also a good idea. Before making it official release, I will have to use it for 1-2 days first. I may like it or may not. So please put the app for testing. But it's still a chance that, Will It be acceptable by everybody. Because there will be 50% of users who might not like it. So whenever you make any UI modification in release app, please put it as an optional in settings. Don't apply it to all users.

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Nov 12, 2022

@simpleavinash We're sorry to hear that you're facing an unexpected problem. However, all the team members mutually decide whether to keep a feature or not.

For your kind information, test APK for 0.24.1 was actually published in #9292 before the official release. If you expressed your problems there, we'd have definitely taken your concerns into account timely.

@simpleavinash
Copy link
Author

simpleavinash commented Nov 12, 2022

@SameenAhnaf I was not active on this forum, I was a normal app user, just a week ago. I came here only after I got the new release.
Thank you for your kind words.

So, what can be done now! Can we put classic view as an option from next releases?

@SameenAhnaf
Copy link
Collaborator

@simpleavinash This is an open-source project. All developers including team members work here for free. As you've opened an issue, it'll attact attention of other developers who are willing to volunteer.

I myself dislike some of the changes of Newpipe throughout the years. However, I'm still patiently waiting for someone to help.

@SameenAhnaf SameenAhnaf added channel group Anything to do with channel groups in the app and removed needs triage Issue is not yet ready for PR authors to take up labels Nov 12, 2022
@somos61
Copy link

somos61 commented Nov 12, 2022

Dear all, Thank you for paying attention to my request.

A. This version24 layout (classic or legacy style) is my first choice. Can you please keep this layout continue to next versions. And keep this (Horizontal scrolling) style also in settings for those who like it, and make it optional to choose the new version24.1 list view.

A

B. If you have to change the channel group to list view, and want to remove the classic group style, then please make an option to customize the size of cards. I want to fit more than 3 (say 6 or 8) cards here.

B

Let me join this exact request. Please, keep channel group old style layout (or make it optional in settings at least). Buttons is too big. Indeed, no need in such a big buttons (list or grid, both)

@FoxSays
Copy link

FoxSays commented Dec 28, 2022

I would also like there to be an option to control this behavior. At the very least, it should not be tied to the list/grid setting as it controls a very different type of user interface element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel group Anything to do with channel groups in the app feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

5 participants