Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos are not completely fullscreen #8774

Open
5 tasks done
PrinceRaj53 opened this issue Aug 13, 2022 · 38 comments
Open
5 tasks done

Videos are not completely fullscreen #8774

PrinceRaj53 opened this issue Aug 13, 2022 · 38 comments
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)

Comments

@PrinceRaj53
Copy link

PrinceRaj53 commented Aug 13, 2022

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.25.1

Steps to reproduce the bug

  1. Play any video
  2. Switch to full screen
  3. Touch the arrow on top right corner
  4. Set the "zoom" option
  5. You'll see that the video is still not completely full screen & there is still space left on the left side.

Expected behavior

The videos should be played full screen.

Actual behavior

The videos are not in fullscreen.

Screenshots/Screen recordings

This is how it should look.

shouldbelikethis

And this is how it looks right now :

nofullscreen

Logs

None.

Affected Android/Custom ROM version

android 12

Affected device model

Realme GT Neo 2 (RMX3370)

Additional information

Tried the debug apks before the final release of latest version. Didn't work. Only version that works is 0.24.1, that too not the final release but a debug apk.

Steps I tried to fix this but didn't work :

  1. Full factory reset

  2. Rolling back to android 11

  3. Setting front camera display of newpipe app to "show front camera"

  4. Changing display cutout setting in developer options

@PrinceRaj53 PrinceRaj53 added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Aug 13, 2022
@AudricV
Copy link
Member

AudricV commented Aug 13, 2022

Was it reproducible on 0.23.1? If so, then it may have been fixed already fixed on the dev version, as the APK should be based on the dev branch (could you confirm, please @Theta-Dev?).

@AudricV AudricV added player Issues related to any player (main, popup and background) waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. and removed needs triage Issue is not yet ready for PR authors to take up labels Aug 13, 2022
@PrinceRaj53
Copy link
Author

Was it reproducible on 0.23.1? If so, then it may have been fixed already fixed on the dev version, as the APK should be based on the dev branch (could you confirm, please @Theta-Dev?).

Well yes, this issue was in 0.23.1 as well.

Like I said, the problem is still present in 0.23.2. Only in the debug apk that I have mentioned above, the videos were in complete fullscreen.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Aug 13, 2022
@PrinceRaj53
Copy link
Author

Sorry, misclicked on "close with comment" option.

@PrinceRaj53
Copy link
Author

Can someone please reopen the issue? i mistakenly closed it.

@opusforlife2
Copy link
Collaborator

If you closed it, you can open it.

@PrinceRaj53
Copy link
Author

So as I said before, the bug was present in the previous version as well as the new version. Only in the debug app it works without issues. The first screenshot("this is how it should've worked") was taken in the debug app.

@goat-oss
Copy link

goat-oss commented Aug 14, 2022

Same error as above on Android 12 on v0.23.1 as well as in 0.23.2.
Only in the debug app it works without issues.
Samsung Device.

@opusforlife2
Copy link
Collaborator

Interestingly, the debug apk that was provided just before 0.23.2 actually shows the video in full screen, edge to edge, without any issues.

It is possible that that debug APK was built with the latest changes of not just the extractor, but also the app, which contains a lot of player improvements. To test this, see if the next full release fixes your issue.

@PrinceRaj53
Copy link
Author

PrinceRaj53 commented Aug 14, 2022

Interestingly, the debug apk that was provided just before 0.23.2 actually shows the video in full screen, edge to edge, without any issues.

It is possible that that debug APK was built with the latest changes of not just the extractor, but also the app, which contains a lot of player improvements. To test this, see if the next full release fixes your issue.

You mean the debug apk is based on dev branch? I see. If only Theta-Dev could confirm it. I'm not sure if I'm allowed to ping him.

Hopefully it does get fixed in the next release, honestly its kind of frustrating to watch videos when they are clipped from one side or from both sides(sometimes its cut from both sides).

For now it seems I'll have to keep using the debug app instead of the full release.

@opusforlife2
Copy link
Collaborator

I'm not sure if I'm allowed to ping him.

If you're polite about it, it's perfectly fine. People usually have problems if you ping them despite their wishes, or mass ping a bunch of people.

when they are clipped from one side or from both sides(sometimes its cut from both sides).

Have you fiddled with Fit/Fill/Zoom? It's next to the subtitle language menu.

@PrinceRaj53
Copy link
Author

when they are clipped from one side or from both sides(sometimes its cut from both sides).

Have you fiddled with Fit/Fill/Zoom? It's next to the subtitle language menu.

Yes. I always set it to zoom when i watch a video to make sure its completely fullscreen but it always has cuts on the sides. Only in the debug app it works as intended.

I hope @Theta-Dev doesn't mind me pinging him.

@AudricV
Copy link
Member

AudricV commented Aug 15, 2022

Could you check if it is also fixed in the APK from this CI run or not?

https://github.com/TeamNewPipe/NewPipe/actions/runs/2856253829

@PrinceRaj53
Copy link
Author

PrinceRaj53 commented Aug 16, 2022

Could you check if it is also fixed in the APK from this CI run or not?

https://github.com/TeamNewPipe/NewPipe/actions/runs/2856253829

Yes it is fixed. Just installed and checked. Though another issue seems to exist : the sound is a bit... different. Low and different.

Edit : There is another bug in 0.23.2. The trending section sometimes show the "no videos" message. Sometimes we have to close and start newpipe 2-3 times to solve this.

I should create a new issue for this bug I think.

@PrinceRaj53
Copy link
Author

PrinceRaj53 commented Aug 23, 2022

Could you check if it is also fixed in the APK from this CI run or not?

https://github.com/TeamNewPipe/NewPipe/actions/runs/2856253829

Update on this : The issue seems started again. Now it cuts the screen from the top & bottom side instead of the left side.

@goat-oss

This comment was marked as off-topic.

@AudricV
Copy link
Member

AudricV commented Aug 23, 2022

Now it cuts the screen from the top & bottom side instead of the left side.

Is it the same issue as #8727?

@PrinceRaj53
Copy link
Author

PrinceRaj53 commented Aug 25, 2022

Now it cuts the screen from the top & bottom side instead of the left side.

Is it the same issue as #8727?

Actually no. In my case the screen cuts on the top and bottom similar to how it showed on the left side. Take the second screenshot of my issue as an example, the "this is how it looks right now" one. Instead of the left side this time, its on the top & bottom side.

Edit : This debug build by theta-dev fixes the issue as well as the other two issues, #8876 and #8835.

@opusforlife2
Copy link
Collaborator

@PrinceRaj53 If the debug build fixed this as well, then you just need to wait for the next major release.

@PrinceRaj53
Copy link
Author

The same problem is showing up in 0.24.1 as well.

@PrinceRaj53
Copy link
Author

Update the description to match the current status.

Did. Sorry about creating a new issue. I didn't find this one at first.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Nov 28, 2022
@PrinceRaj53
Copy link
Author

Still happening. Does not happen in beta builds but always happens in final builds.

@PrinceRaj53
Copy link
Author

Checked the latest version. This time its worse. Even more area is left on the left side.

Are there any other debug builds like last time that I can test to see if that works? Its really annoying to use newpipe like this.

@opusforlife2
Copy link
Collaborator

Wait for the next point release.

@PrinceRaj53
Copy link
Author

PrinceRaj53 commented Apr 8, 2023

Wait for the next point release.

Just tested the latest one, 0.25.1. Same issue. As usual, now I'm using an old debug apk of 0.24.1.

@opusforlife2
Copy link
Collaborator

Could you update the description with the latest image of this bug?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 8, 2023
@PrinceRaj53
Copy link
Author

PrinceRaj53 commented Apr 9, 2023

Could you update the description with the latest image of this bug?

Its the same actually. Thats why I didn't update any latest pictures. I'll do it now.

Edit : Done. As you can see, its the same problem. In fact, its worse this time as more space is left on the left side.

Anyways, just a little info, in case it helps : #9812 fixed my issue, but only if I use that specific debug apk. The issue is still present in the release apk, 0.25.1.

See, everytime there is a fix for some issue, or in this case, this debug apk from the pull request, it fixes my issue as well. But after the main release apk is out, if I try that, the issue starts again. Probably something gets changed in the main release that triggers this.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 9, 2023
@opusforlife2
Copy link
Collaborator

opusforlife2 commented Apr 9, 2023

Could you take a backup and try with a fresh install? Don't change any settings.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 9, 2023
@PrinceRaj53
Copy link
Author

PrinceRaj53 commented Apr 10, 2023

Could you take a backup and try with a fresh install? Don't change any settings.

I do that every time there is a new release. The screenshots I gave are from the release apk, complete default settings, without importing anything.

Here's another example, see this 0.25.1 debug apk works perfectly, no issues. Immersive fullscreen is there.

But with the main release, the problem's still there.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 10, 2023
@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Apr 10, 2023

Most likely, something is wrong with your system settings.

  1. Go to Settings app
  2. Select Display & Brightness
  3. Select Screen display
  4. Select Front camera display by app
  5. Select Newpipe
  6. Select Show Front Camera

Let us know if that works for you.

@SameenAhnaf SameenAhnaf added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 10, 2023
@opusforlife2
Copy link
Collaborator

I don't have this Screen display menu. Is it something specific to Oppo/Realme?

@SameenAhnaf
Copy link
Collaborator

Yes, this option is in Realme UI

@PrinceRaj53
Copy link
Author

PrinceRaj53 commented Apr 11, 2023

Most likely, something is wrong with your system settings.

  1. Go to Settings app
  2. Select Display & Brightness
  3. Select Screen display
  4. Select Front camera display by app
  5. Select Newpipe
  6. Select Show Front Camera

Let us know if that works for you.

That's actually what I thought of at first and tried before I posted the issue here. In fact, with every release I try that first, to see if thats the reason why immersive fullscreen is not showing. After installing newpipe everytime it sets to auto adapt, and I set it to show front camera before using. Like I said before, #9812 fixed my issue, but only if I use that specific debug apk. 0.25.1 debug apk works too(I dont use it as its not that stable), but not the main release.

These two apks work even without setting it to show front camera. Right now i'm using #9812's debug apk and its set to "auto adapt", and its still working.

Basically I tried everything I could think of, including factory reset as well as rolling back to android 11. Absolutely nothing worked on my end.

I tested this in two other phones that my friend has. One is a redmi(dont remember the model) and the other is asus zenfone max pro m1(the 3GB model). Same issue in both of them as well.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 11, 2023
@opusforlife2
Copy link
Collaborator

What's your Display Cutout setting in Developer Options?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 11, 2023
@PrinceRaj53
Copy link
Author

PrinceRaj53 commented Apr 11, 2023

What's your Display Cutout setting in Developer Options?

I did try changing that yesterday to every setting. Didn't work. As of now I've set it back to device default.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 11, 2023
@ChipsEatingPenguin
Copy link

I do have this issue as well just on a vastly different device

Samsung SM-P900
Android 5.0.2
Newpipe 0.25.1
When I choose to zoom the video to fill the screen (16:10 ratio) Right 1:10th of the screen gets a vertical black bar

@opusforlife2
Copy link
Collaborator

Probably has something to do with the code that accounts for software vs hardware navbar, if display cutouts are eliminated, as stated above.

@mtaras0
Copy link

mtaras0 commented Nov 9, 2023

The bug is still happening, on release versions and on the current 26 RC. My device is an old tablet with Android 5, no notch no nothing, Zoom does zoom the video, but shifts it around depending on the viewing mode -- in fullscreen it's shifted to the left with the black bar on the right, when not in fullscreen it's shifted to the top, bottom half of the player is black. Looks like the shift is going in the opposite direction, like the sign is flipped, the amount of black space is about how much video should've been cut off by being zoomed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

7 participants