Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Support for opt-in setting for Opus downloads #837

Closed
2 tasks done
sigmarelax opened this issue Nov 11, 2017 · 4 comments
Closed
2 tasks done

[Request] Support for opt-in setting for Opus downloads #837

sigmarelax opened this issue Nov 11, 2017 · 4 comments
Labels
feature request Issue is related to a feature in the app

Comments

@sigmarelax
Copy link

  • I carefully read the contribution guidelines and agree to them.
  • I checked if the issue/feature exists in the latest version.

Opus downloads have been left out due to inconsistent support on pre-Android 5.0 devices. This is unfortunate because the audio-only bitrate for most videos in NewPipe is 128kbps, even though Opus@160 is available. Additionally, low bitrate Opus is very efficient and the codec is more free/libre than AAC.

I propose adding a setting for NewPipe that enables Opus downloads (with default=false). Here's a quick mockup: https://i.imgur.com/97Gsjij.png

Opus has been mentioned in other submitted issues, but a similar proposal has not been made. Adding this option for users is appropriate at this point since 80% of all Android devices are on 5.0+. This percentage is likely higher for the install-base of NewPipe and will only continue going up.

@theScrabi
Copy link
Member

Sounds reasonable.

@theScrabi theScrabi added the feature request Issue is related to a feature in the app label Nov 12, 2017
@ghost
Copy link

ghost commented Nov 14, 2017

I'm honestly surprised this was the reason for leaving it out when Newpipe is supposed to be a libre-alternative to Youtube and libre Opus downloads would have served millions of people just fine.

@theScrabi
Copy link
Member

But I remember two years ago when I maped the youtube itags to the corresponding formats that I used a slightly outdated list, and I only mapped a small part of that list. I'm with you tho opus support should be added.

@ghost ghost mentioned this issue Feb 4, 2018
2 tasks
@theScrabi
Copy link
Member

will be closed in the sake of #1059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

2 participants