Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos can't have "watched" status and/or "Remove watched" doesn't work and/or "playback position" feature is bugged #7563

Closed
4 tasks done
Tallefer opened this issue Dec 21, 2021 · 4 comments · Fixed by #8259
Assignees
Labels
bug Issue is related to a bug

Comments

@Tallefer
Copy link

Checklist

Steps to reproduce the bug

  1. Make a playlist and add videos to it
  2. Play one or more of those videos till the end or/and use "Mark as watched" from video's context (long tap) menu
  3. A red progress bar under each watched video should be visible now (it is not immediately visible in the "What's new" tab so either go to the playlist or press "Refresh", not sure if it isn't another bug)
  4. In the playlist view press "Remove watched', then "Yes".

Actual behavior

  • No videos are removed.
  • The red progress bar often (not always) misses a chunk from its end, most noticeable on short (3-5 min or less) videos.

Expected behavior

  • All completely watched videos should be removed.
  • All completely watched videos should have a full red bar under them.

Just a wild guess - bug could be related to how preloading next video while still playing the current one is implemented, based on those incomplete red bars.

Screenshots/Screen recordings

Logs

Device info

  • Android version/Custom ROM version: 5.1.1
  • Device model: SM-J120F
@Tallefer
Copy link
Author

Tallefer commented Dec 21, 2021

This bug is present for at least 6 months, probably more, but the removal feature worked just fine for some time since its introduction.

@LingYinTianMeng
Copy link
Contributor

LingYinTianMeng commented Apr 17, 2022

I want to work on this issue, I am working on it and I think I can fix it soon

@LingYinTianMeng
Copy link
Contributor

I guess the original code just forgot to take into account the condition if the video is finished, I'll try to add it

@LingYinTianMeng
Copy link
Contributor

I think I've fixed it, can you assign it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants