Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to open hamburger menu on search results page #6821

Open
3 tasks done
infinitewaveparticle opened this issue Aug 1, 2021 · 4 comments
Open
3 tasks done

Add way to open hamburger menu on search results page #6821

infinitewaveparticle opened this issue Aug 1, 2021 · 4 comments
Labels
feature request Issue is related to a feature in the app

Comments

@infinitewaveparticle
Copy link

infinitewaveparticle commented Aug 1, 2021

Checklist

Describe the feature you want

It would be nice to be able to access the hamburger menu from everywhere - including from search results. As of now swiping from the left edge of the screen does nothing on the search results page. This would be a potential way to do it since it would keep it consistent throughout the app.

Any alternative ideas are welcome.

Is your feature request related to a problem? Please describe it

No

Additional context

An older PR in this direction: #3156

How will you/everyone benefit from this feature?

As mentioned above it would keep this gesture consistent throughout the app. It would also allow users to adjust settings and return to their search results without having to search again. This would be particularly useful for users who have scrolled down the search results a long distance.

@infinitewaveparticle infinitewaveparticle added the feature request Issue is related to a feature in the app label Aug 1, 2021
@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Aug 1, 2021

If such a feature is added, "Back" button on search menu should be replaced by "Hamburger" icon.

Because, many phones have "Swiping from left edge" as back button. So gesture for hamburger won't work on those phones.

Also, 'Back' button should be replaced by 'Hamburger' in these places.

  1. Queue manager
  2. Channel feed
  3. Playlist feed
  4. All options in drawer

@infinitewaveparticle

This comment has been minimized.

@infinitewaveparticle
Copy link
Author

Related to #5399

@page200
Copy link

page200 commented Aug 16, 2023

In fact, navigation back and forth between various things should be possible: search results, currently playing online video, downloads, ... These things can be in different tabs that the user can't hide, and the tab bar can be always visible. See issue #10327.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

3 participants