Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 6 options on "Exit video from full screen" in settings #5675

Closed
3 tasks done
SameenAhnaf opened this issue Feb 22, 2021 · 1 comment
Closed
3 tasks done

Add 6 options on "Exit video from full screen" in settings #5675

SameenAhnaf opened this issue Feb 22, 2021 · 1 comment
Labels
feature request Issue is related to a feature in the app

Comments

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Feb 22, 2021

Checklist

Describe the feature you want

In current version, Newpipe plays the background on exit. This might not fulfill everyone's needs. Plus, one need to tap thrice to fully exit from a full screen video. Once, to return to video info. Twice, to start playing on background. Thrice, to cancel streaming. Nobody actually needs so many options at once!!!

Here are my suggested options on "Exit video from full screen".

  1. Main player: Continue viewing video in main player after exiting full screen. Tap back once again to fully exit.
  2. None: Playing full screen video will be turned off just after tapping back once.
  3. Play popup: Playing full screen video will switch to popup
  4. Play background: Playing full screen video will switch to background
  5. YouTube: Recommended for default option. Quite similar to as of now but not the same. Currently, if we minimize the main player within the app, the video starts playing behind title bar. However, this is pretty strange and should be fixed. The video should be playing on thumbnail just like YouTube app.
  6. Always ask: A popup with "Main player", "Background", "Popup" and "Exit video" will appear. If no option is chosen before tapping back once again, the video will continue playing on full screen.

Is your feature request related to a problem? Please describe it

Additional context

How will you/everyone benefit from this feature?

Users won't need to toil too much while switching between players as users will be able to choose when to do what. I wanted to keep Newpipe simple as the past days. Play the video and enter full screen. Press back button and exit the video. However, advanced options are still there for fulfilling needs of all users.

@SameenAhnaf SameenAhnaf added the feature request Issue is related to a feature in the app label Feb 22, 2021
@SameenAhnaf SameenAhnaf changed the title Add 5 options on "Exit video" Add 5 options on "Exit video" within the app Feb 24, 2021
@SameenAhnaf SameenAhnaf changed the title Add 5 options on "Exit video" within the app Add 4 options on "Exit video" within the app Mar 27, 2021
@SameenAhnaf SameenAhnaf changed the title Add 4 options on "Exit video" within the app Add 4 options on "Exit video from full screen" in settings Mar 29, 2021
@SameenAhnaf SameenAhnaf changed the title Add 4 options on "Exit video from full screen" in settings Add 7 options on "Exit video from full screen" in settings Mar 29, 2021
@SameenAhnaf SameenAhnaf changed the title Add 7 options on "Exit video from full screen" in settings Add 6 options on "Exit video from full screen" in settings Apr 10, 2021
@futureisfoss
Copy link

Hey, this is a nice feature and would go well with #5459. Why is this issue closed though ? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

2 participants