Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Video Controls #4423

Closed
Nzzyme opened this issue Oct 6, 2020 · 2 comments
Closed

Lock Video Controls #4423

Nzzyme opened this issue Oct 6, 2020 · 2 comments
Labels
feature request Issue is related to a feature in the app

Comments

@Nzzyme
Copy link

Nzzyme commented Oct 6, 2020

Hello, I was thinking that it would be a good idea to add a 'lock' icon on the video player so that when we tap on that and enable locking, all the player controls would be freezed so that even when we swipe up on the right side, the volume should not go up, etc.

Similarly, when we tap on the lock icon again to unlock it, the controls should be working again normally.

This is already implemented in many media players like MX Player (for example) and would be good to have it in NewPipe too. Can you please consider this and add this feature?

Thanks

@Nzzyme Nzzyme added the feature request Issue is related to a feature in the app label Oct 6, 2020
@opusforlife2
Copy link
Collaborator

You deleted all the check boxes. You were supposed to go through them. One of them was looking for duplicates. And now this issue will be closed because you didn't. #1575 :(

@Nzzyme
Copy link
Author

Nzzyme commented Oct 6, 2020

Apologies. Let me go through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

2 participants