Please make your metadata OPTIONAL!

[shuttittuppitt]

I used "New pipe" (0.19.5) to download a video from youtube. The video plays as expected. However, I looked at the video with "Media info" for android, & I found this.

"Title: ISO Media file created in NewPipe (A libre lightweight streaming frontend for Android)."

The addition of this METADATA is a privacy concern. It's also not needed in order to PLAY a video. Plus, adding any metadata to ANY file always increases that file's size.

Give us the OPTION of NOT adding ANY metadata to a downloaded video.

[TobiGr]

NewPipe/app/src/main/java/org/schabi/newpipe/streams/Mp4FromDashWriter.java

Lines 851 to 867 in 9cf76a9

	private byte[] makeHdlr(final Hdlr hdlr) {
	ByteBuffer buffer = ByteBuffer.wrap(new byte[]{
	0x00, 0x00, 0x00, 0x77, 0x68, 0x64, 0x6C, 0x72, // hdlr
	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
	// binary string
	// "ISO Media file created in NewPipe (
	// A libre lightweight streaming frontend for Android)."
	0x49, 0x53, 0x4F, 0x20, 0x4D, 0x65, 0x64, 0x69, 0x61, 0x20, 0x66, 0x69, 0x6C, 0x65,
	0x20, 0x63, 0x72, 0x65, 0x61, 0x74, 0x65, 0x64, 0x20, 0x69, 0x6E, 0x20, 0x4E, 0x65,
	0x77, 0x50, 0x69, 0x70, 0x65, 0x20, 0x28, 0x41, 0x20, 0x6C, 0x69, 0x62, 0x72, 0x65,
	0x20, 0x6C, 0x69, 0x67, 0x68, 0x74, 0x77, 0x65, 0x69, 0x67, 0x68, 0x74, 0x20, 0x73,
	0x74, 0x72, 0x65, 0x61, 0x6D, 0x69, 0x6E, 0x67,
	0x20, 0x66, 0x72, 0x6F, 0x6E, 0x74, 0x65, 0x6E, 0x64, 0x20, 0x66, 0x6F, 0x72, 0x20,
	0x41, 0x6E,
	0x64, 0x72, 0x6F, 0x69, 0x64, 0x29, 0x2E
	});

Line 856 - 866 should be removed.

[wb9688]

@TobiGr: You can't just remove all those bytes and expect it to work…

[TobiGr]

That's what we need to test. I guess, we can replace them with 0x00

[wb9688]

@TobiGr: No, you should read what the specification says, and possibly look at other implementations, not just guess

[TobiGr]

Found one more:

NewPipe/app/src/main/java/org/schabi/newpipe/streams/Mp4FromDashWriter.java

Line 729 in 9cf76a9

0x4E, 0x65, 0x77, 0x50, 0x69, 0x70, 0x65 // "NewPipe" binary string

PS: The specification is here

[mgolden356]

@shuttittuppitt I can't find this metadata on properties on any of my file manager apps. How would I be able to view this metadata?

[shuttittuppitt]

I found it when I used this on a video that I downloaded. I usually use it to find a video's bit rate, among other things.

https://play.google.com/store/apps/details?id=net.mediaarea.mediainfo

[ghost]

This metadata also draws attention to NewPipe. I don't know what effect a DMCA takedown would have on the development.

[ghost]

Please make your metadata OPTIONAL!

And off by default, of course (if needed at all).

[TobiGr]

We will remove that completely. @kapodamy Do you have time to help us with that?

[shuttittuppitt]

@TobiGr
I just remembered that according to "Media info", that same metadata is included not only for the "video" part of the downloaded video, but also for the "audio" part too. So there may be another part of the source code that has it specifically for the audio part.

[kapodamy]

@TobiGr
Yes i can, but dont scare me