Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio sessions are not closed properly #3644

Closed
Ch3ri0ur opened this issue May 24, 2020 · 1 comment
Closed

Audio sessions are not closed properly #3644

Ch3ri0ur opened this issue May 24, 2020 · 1 comment
Labels
bug Issue is related to a bug

Comments

@Ch3ri0ur
Copy link

I recently got the app Wavelet (https://play.google.com/store/apps/details?id=com.pittvandewitt.wavelet).

I noticed in Wavelet, that the audio sessions of NewPipe don't get closed properly.

The author of Wavelet already noticed such a behavior in Spotify and wrote a bug report there:

https://community.spotify.com/t5/Ongoing-Issues/Android-Audio-sessions-are-not-opened-and-closed-properly/idi-p/4861998

Quote:
""https://developer.android.com/reference/android/media/audiofx/AudioEffect.html#ACTION_CLOSE_AUDIO_EFFECT_CONTROL_SESSION
If this intent is not broadcasted, audio effects that were applied to this session stay applied. This causes some effects not to be available to any other audio session and unnecessary consumption of system resources.""

I think this is a similar issue.

Version

  • 0.19.3

Steps to reproduce the bug

  1. Install Wavelet
  2. Start Wavelet and activate AutoEQ
  3. Start NewPipe and open a Video
    -> Notice that a instance of NewPipe is registered in the Wavelet notification
  4. Start another Video
    -> Another instance is registered.
    Screenshot_20200523-115043
  5. After the 3rd instance Wavelet starts throwing errors ( the reason I noticed this )
    Screenshot_20200523-1157362

Expected behavior

Only ever one instance in Wavelet, which closes as soon as I stop using NewPipe.

Actual behavior

The instances in Wavelet stack indefinitely and never close.

@Ch3ri0ur Ch3ri0ur added the bug Issue is related to a bug label May 24, 2020
@Stypox
Copy link
Member

Stypox commented May 24, 2020

Duplicate of #2373

@Stypox Stypox closed this as completed May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants