Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails preview on seek bar #3207

Closed
heberjeur opened this issue Mar 9, 2020 · 10 comments · Fixed by #6434
Closed

Thumbnails preview on seek bar #3207

heberjeur opened this issue Mar 9, 2020 · 10 comments · Fixed by #6434
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@heberjeur
Copy link

Youtube offers a way to preview the frames when hovering the progress bar. This is very convenient when you want to go directly to a certain moment of a video or to watch it again.
Screenshot_20200309-182505

@wb9688 wb9688 added feature request Issue is related to a feature in the app requires extractor change This issue requires a change to the extractor labels Mar 10, 2020
@FreddieOliveira
Copy link

I'd love to have that feature

@Stypox Stypox added GUI Issue is related to the graphical user interface and removed requires extractor change This issue requires a change to the extractor labels May 7, 2020
@B0pol
Copy link
Member

B0pol commented May 22, 2020

Invidious has this feature and it's called storyboard by YouTube.
It's available via playerResponse.storyboards.playerStoryboardSpecRenderer.spec.
The relevant code is here and here (not exactly this line, scroll down a bit).

@MD77MD
Copy link

MD77MD commented Aug 13, 2020

this would be awesome if it can be added to newPipe 0.20.1

@opusforlife2
Copy link
Collaborator

@MD77MD It would be awesome if this could be added to any version.

@MD77MD
Copy link

MD77MD commented Aug 16, 2020

sometimes I just wonder how could the newPipe members find the time to implement all these great ideas.

@litetex
Copy link
Member

litetex commented Jun 4, 2021

Spoiler alert:
I was a bit annoyed that this feature is still missing and tried to implement it by myself.
Worked out pretty well so far:
grafik

Hopefully I'll be able to create a pull request in the next few days - if everything is final and working fine 😄

@Mhowser
Copy link

Mhowser commented Jun 5, 2021

That's awesome @litetex! Have you made a pull request yet?

@opusforlife2
Copy link
Collaborator

That's awesome litetex! Have you made a pull request yet?

@Mhowser So excited you forgot to read the last line of the comment? xD

@litetex
Copy link
Member

litetex commented Jun 5, 2021

That's awesome litetex! Have you made a pull request yet?

@Mhowser So excited you forgot to read the last line of the comment? xD

😆

Anyway, the PR is now ready → #6434

Happy reviewing 😉

@Mhowser
Copy link

Mhowser commented Jun 7, 2021

That's awesome litetex! Have you made a pull request yet?

@Mhowser So excited you forgot to read the last line of the comment? xD

Yep lol, my ADHD brain does this a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants