Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background video title not showing on lockscreen and a request #1467

Closed
chris47368 opened this issue Jun 10, 2018 · 9 comments
Closed

Background video title not showing on lockscreen and a request #1467

chris47368 opened this issue Jun 10, 2018 · 9 comments
Assignees
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface

Comments

@chris47368
Copy link

chris47368 commented Jun 10, 2018

Hey Newpipe team,well done implementing the media controls on the lock screen that i and others suggested not too long back.

There is an issue however on the lock screen media control where the title of the background video being played is not shown.You may or may not already be aware of this issue but fixing this issue for the next version release would be great :) but im still very happy and grateful about the huge amount of progress your team are making on this app.

I also have another request.Is it possible that while saving a video as a sound file that you can give the user a way to modify the song tags such as title and artist/album .Also allowing to save a sound file at a higher bit rate would be good too.

The app can also randomly crash in the background after a while,its a minor but annoying issue but i have sent the crash logs via email anyway and hopefully its fixed soon in the later versions.

Thanks again Newpipe development team!!!

Edit:
Sorry i forgot to mention this but could you also add support for time-stamped YouTube links so when you open the link into newpipe the video automatically starts on the time within the link? I forgot to mention this while writing this post and did not want to create a second post

Thanks again Newpipe Dev team!!!

@theScrabi
Copy link
Member

Hello thank you :D. The props for the medio controllger go to @karyogamy.

I also have another request.Is it possible that while saving a video as a sound file that you can give the user a way to modify the song tags such as title and artist/album .Also allowing to save a sound file at a higher bit rate would be good too.

There where discussions about this already, but so far no code. However please open up a new issue for this.

@karyogamy
Copy link
Contributor

There is an issue however on the lock screen media control where the title of the background video being played is not shown.

Are you referring to the popup video player or the background audio player?

the title of the background video being played is not shown

Does it show any notification or is it just the title not showing? Can you please provide a screenshot if its just the title?

The app can also randomly crash in the background after a while,its a minor but annoying issue but i have sent the crash logs via email anyway and hopefully its fixed soon in the later versions.

Can you please provide a log or screenshot of the error here? Can't seem to find any recent crash log coming from the background player. Are you on the latest version?

@chris47368
Copy link
Author

chris47368 commented Jun 15, 2018

"There is an issue however on the lock screen media control where the title of the background video being played is not shown."

This issue is with the Newpipe background player as shown below:
https://imgur.com/VKhOQND

When I play music from my local music player(poweramp in this example) the lock screen controls show the song title and artist like below :
https://imgur.com/a/Ofppvc8

As you can see the title of the video is not showing on the lockscreen control of the background player.But the video title does show up as normal inside the notifications as shown below:
https://imgur.com/a/qyaF3qd

"Can you please provide a log or screenshot of the error here? Can't seem to find any recent crash log coming from the background player. Are you on the latest version?"
I just posted the error report below:
https://pastebin.com/sc1qE9YP

And yes to my knowledge its the latest version.

Thank you for replying back :)

@karyogamy
Copy link
Contributor

Thanks for the clarification.

This issue is with the Newpipe background player as shown below:

I'll have to look into this a little more, but this might have something to do with MediaBrowser not implemented at the moment. It's quite strange that the metadata is passed to android wear and auto but not to notification access like in your case.

I just posted the error report below:

This should be fixed in #1392, though it might take some more time before it is tested and merged.

@chris47368
Copy link
Author

Thanks :)

@karyogamy
Copy link
Contributor

An update on the missing title issue:
Apparently this is caused by exoplayer itself, where it is not exposing the title through all the title metadata tags. Since third party widgets have multiple different choices for getting the title metadata, if it chose the wrong one out of the ones available, it will get a blank metadata.

After updating to exoplayer 2.8.2 in #1392, this issue is fixed for the titles. But because of the above issue, the artist and album info is still going to be missing.

@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2018
@Stypox
Copy link
Member

Stypox commented Jul 10, 2019

Related: #228

@TobiGr TobiGr removed the stale label Jul 19, 2019
@Stypox Stypox added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Aug 27, 2019
@Stypox
Copy link
Member

Stypox commented Aug 27, 2019

The first one is fixed (as the author says in #1568) and the second one is duplicate of #183

@Stypox Stypox closed this as completed Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

5 participants