Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"implement me" bug #1228

Closed
theScrabi opened this issue Mar 30, 2018 · 6 comments
Closed

"implement me" bug #1228

theScrabi opened this issue Mar 30, 2018 · 6 comments

Comments

@theScrabi
Copy link
Member

If you enable a soundcloud kiosk as frontpage, and go back to the frontpage you will get an error:

screenshot_20180330-201843

The snagbar for this error always shows up, however its particular nasty because you cant access the settings in the drawer enymore in order to turn off the kiosk.

However if you want to read the error the message is "implement me"

... this however is my fault, I've deaktivated kisok for soundcloud once.

@theScrabi theScrabi added the ASAP Issue needs to be fixed as soon as possible label Mar 30, 2018
@karyogamy
Copy link
Contributor

I can't seem to reproduce the error, but for the snackbar, maybe it's a good idea to add a dismiss button to it.

@theScrabi
Copy link
Member Author

maybe it's a good idea to add a dismiss button to it.

that would not help since the error is instantly risen again. I/we just had to fix the error I produced by writing that "implement me" thing.

can't seem to reproduce the error

On the current version you can still access the settings via dropdown menu, however I'm working on a branch where I remove beta builds, and therefore also the redundant items in the dropdown menu. Then this issue will be a problem for us.

@theScrabi theScrabi removed the ASAP Issue needs to be fixed as soon as possible label Mar 30, 2018
@karyogamy
Copy link
Contributor

Oh, I was on the removebeta branch and can't reproduce any error on returning to main fragment after changing the page to soundcloud kiosk.

that would not help since the error is instantly risen again.

Something might be wrong internally, then, since something has to constantly spewing out errors to make the snackbar reappear instantly.

@theScrabi
Copy link
Member Author

Something might be wrong internally, then, since something has to constantly spewing out errors to make the snackbar reappear instantly.

I see ...

@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2018
@TobiGr TobiGr removed the stale label Jul 19, 2019
@Stypox
Copy link
Member

Stypox commented Jul 19, 2019

SoundCloud Kiosk pages now can't be added from the "Content of main page" option, so this is not an issue anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants