Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommentRepliesSource: App Crash after being offline #11717

Open
Profpatsch opened this issue Nov 18, 2024 · 0 comments
Open

CommentRepliesSource: App Crash after being offline #11717

Profpatsch opened this issue Nov 18, 2024 · 0 comments
Labels
bug Issue is related to a bug comments Anything to do with comments and comment replies under videos/audios rewrite Issues and PRs related to rewrite

Comments

@Profpatsch
Copy link
Contributor

Profpatsch commented Nov 18, 2024 •
edited
Loading

The app crashes when trying to load comment replies when being offline after comments have been loaded with a network connection at this exact line (it should also happen on comment continuations). This must be fixed.

Originally posted by @AudricV in #11060 (comment)

NewPipe/app/src/main/java/org/schabi/newpipe/paging/CommentRepliesSource.kt

Line 21 in fdf36cb

CommentsInfo.getMoreItems(service, commentInfo.url, repliesPage)

@Profpatsch Profpatsch changed the title The app crashes when trying to load comment replies when being offline after comments have been loaded with a network connection at this exact line (it should also happen on comment continuations). This must be fixed. CommentRepliesSource: App Crash after being offline Nov 18, 2024
@Profpatsch Profpatsch added bug Issue is related to a bug ASAP Issue needs to be fixed as soon as possible labels Nov 18, 2024
@Profpatsch Profpatsch moved this to Todo in Rewrite Nov 18, 2024
@AudricV AudricV added comments Anything to do with comments and comment replies under videos/audios rewrite Issues and PRs related to rewrite and removed ASAP Issue needs to be fixed as soon as possible labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue is related to a bug comments Anything to do with comments and comment replies under videos/audios rewrite Issues and PRs related to rewrite
Projects
Rewrite
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Profpatsch @AudricV