Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Create update broke Flywheel dependency #51

Open
FemBane opened this issue Sep 3, 2024 · 6 comments
Open

[Bug] Create update broke Flywheel dependency #51

FemBane opened this issue Sep 3, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@FemBane
Copy link

FemBane commented Sep 3, 2024

Error Behaviour

image
Create Updated to Flywheel 6.11-13

Expected Behaviour

Update the upper bound for Flywheel versions

Reproduce

Install Create 1.20.1 v0.5.1h and steampowered-1.20.1-3.0.1.jar
This will happen

Crash Report

No response

Mod version

3.0.1

Server version

No response

Other mods and plugins

No response

@FemBane FemBane added the bug Something isn't working label Sep 3, 2024
@Oxy49
Copy link

Oxy49 commented Sep 3, 2024

Follow up ⬆️

@FemBane
Copy link
Author

FemBane commented Sep 4, 2024

I just want my boilers ;(

@SoOPlayer4400
Copy link

Im also having the same issue

@therealKoolant
Copy link

bump

@Xalcon
Copy link

Xalcon commented Sep 9, 2024

Mods should not depend on the dependencies of other mods when they already depend on the mod. Depending on create 0.5.1+ already implies a dependency on flywheel.
The project does not seem to reference the flywheel library at all (no reference to dev.engine_room.flywheel), which means an explicit dependency is just harmful. If create decides to remove flywheel in a minor update, this mod would break again. Having it in the build.gradle is more than sufficient.

For people that look for a temporary fix:
You can open the steampowered jar file and edit the mods.toml inside the META-INF directory.
In there you can either remove the whole dependency block for flywheel or change the version requirement for flywheel from the old

    versionRange="[0.6.10,0.6.11)"

to something like this:

    versionRange="[0.6.10,)"

The jar file is not signed, so editing its content is fine for personal use.

@IslamSir
Copy link

Same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants