Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of new-style OpenSSH key files #1485

Closed
hvdijk opened this issue Oct 24, 2018 · 3 comments
Closed

Improve handling of new-style OpenSSH key files #1485

hvdijk opened this issue Oct 24, 2018 · 3 comments
Assignees
Labels
Issue-Feature A feature request or improvement.

Comments

@hvdijk
Copy link

hvdijk commented Oct 24, 2018

When using the new SFTP functionality (looking very nice, by the way!), when attempting to load a private key in the new-ish OpenSSH format (the type that begins with -----BEGIN OPENSSH PRIVATE KEY-----), the key will not load. A prompt is shown asking for a passphrase, but no matter what passphrase is entered, it will not be accepted.

This new private key format has been made the default as of OpenSSH 7.8, and as I created a new key for use on my phone, I inadvertently created one in this new format. I can understand that it may not be feasible to implement support for this format in a short time, but would it be possible to give a more useful error message?

@VishalNehra
Copy link
Member

Exactly the problem I had. @TranceLove can you please give this a look.

@TranceLove TranceLove self-assigned this Oct 25, 2018
@TranceLove
Copy link
Collaborator

According to hierynomus/sshj#276, support is already there.

I'm also submitting a new PR with upgraded sshj and Espresso test to verify the behaviour.

@EmmanuelMess
Copy link
Member

This should be fixed, test in next release candidate (next sunday) or by compiling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature A feature request or improvement.
Projects
None yet
Development

No branches or pull requests

4 participants