Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling for find_movie method #203

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Improve error handling for find_movie method #203

merged 2 commits into from
Apr 7, 2021

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Apr 7, 2021

No description provided.

glensc added 2 commits April 7, 2021 23:48
@glensc
Update find_movie error to include what is wrong id_type value
8a07d03
@glensc
Catch JSONDecodeError before ValueError
9fc9cb7 
As JSONDecodeError is subclass of ValueError,
it needs to be caught before to be able to catch it
@glensc glensc self-assigned this Apr 7, 2021
@glensc glensc changed the title Update find_movie error to include what is wrong id_type value Improve error handling for find_movie method Apr 7, 2021
@glensc
Copy link
Collaborator Author

glensc commented Apr 7, 2021

The JSONDecodeError happens when api calls performed with invalid parameters:

@glensc glensc merged commit 586dbce into Taxel:main Apr 7, 2021
@glensc glensc deleted the errors branch April 7, 2021 20:54
@glensc glensc mentioned this pull request Apr 10, 2021
Merged
Repository owner locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@glensc