Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite nocache as function to support decorators on class method arguments #183

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Rewrite nocache as function to support decorators on class method arguments #183

merged 1 commit into from
Apr 5, 2021

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Apr 5, 2021

Extracted from #180

otherwise methods being decorated with @nocache got their arguments shifted around.

    @nocache
    def rate(self, m, rating):
        m.rate(rating)

this was called with two arguments only: m, rating.

@glensc glensc self-assigned this Apr 5, 2021
@glensc glensc merged commit 92ec606 into Taxel:main Apr 5, 2021
@glensc glensc deleted the nocache-decorator-method-parameters branch April 5, 2021 22:06
@glensc glensc mentioned this pull request Apr 10, 2021
Merged
Repository owner locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@glensc