New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Get rid of pytrakt_extensions (port functionality to pytrakt) #1862

Open

glensc opened this issue Mar 14, 2024 · 0 comments

Labels

Collaborator

glensc commented Mar 14, 2024 •

edited

Loading

Feature description

Use case

Similarly to #1826

There's still some code left that's hacking pytrakt internals:

https://github.com/Taxel/PlexTraktSync/blob/dd1bfa22c52bc8eb651a7159bf43f9ef7226c33b/plextraktsync/pytrakt_extensions.py

More specifically:

watched_shows:

PlexTraktSync/plextraktsync/trakt/TraktApi.py

Lines 120 to 121 in dd1bfa2

def watched_shows(self):

return pytrakt_extensions.allwatched()
collected_shows:

PlexTraktSync/plextraktsync/trakt/TraktApi.py

Lines 126 to 127 in dd1bfa2

def collected_shows(self):

return pytrakt_extensions.allcollected()

The plan is to get rid of it and add missing functionality to pytrakt if needed.

glensc added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment