From eb0106711e201d4046d668d91cccf84009f62fa5 Mon Sep 17 00:00:00 2001 From: Ryan Gribble Date: Mon, 14 Dec 2015 11:44:17 +1000 Subject: [PATCH] potential fix to convention test problems with private setter on IGenericList --- Octokit.Tests.Conventions/ModelTests.cs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Octokit.Tests.Conventions/ModelTests.cs b/Octokit.Tests.Conventions/ModelTests.cs index f126e8cd57..c0b2dd8cc3 100644 --- a/Octokit.Tests.Conventions/ModelTests.cs +++ b/Octokit.Tests.Conventions/ModelTests.cs @@ -85,6 +85,12 @@ public void ResponseModelsHaveReadOnlyCollections(Type modelType) continue; } + // Let's skip collections that only have a private Setter + if (property.SetMethod != null && property.SetMethod.IsPrivate) + { + continue; + } + mutableCollectionProperties.Add(property); } }