Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix solid adapter in alpha version #5815

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Fix solid adapter in alpha version #5815

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53e8077
fix solid adapter
riccardoperra Nov 23, 2024
aa59425
fix
riccardoperra Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/solid-table/src/createTable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ export function createTable<
...tableOptions,
_features,
state: { ...store, ...tableOptions.state },
mergeOptions: (defaultOptions, options) => {
return mergeProps(defaultOptions, options)
},
onStateChange: (updater) => {
setStore(updater)
tableOptions.onStateChange?.(updater)
Expand All @@ -38,6 +41,7 @@ export function createTable<
createComputed(() => {
table.setOptions((prev) => {
return mergeProps(prev, tableOptions, {
_features: { ...coreFeatures, ...tableOptions._features },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this, without that I think the new options will not contains the coreFeatures

state: mergeProps(store, tableOptions.state || {}),
onStateChange: (updater: Updater<TableState<TFeatures>>) => {
setStore(updater)
Expand Down
Loading