fix(vue): make normal JS-getters work, make reactivity a non-breaking change #5702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6b45d50. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, I just want to say I'm sorry for the inconvenience with the bugs introduced as part of my attempt to make reactivity-support in the Vue-adapter 😇
Hopefully this PR will fix all the issues that has been reported. This PR will fix the following:
refis not being used, the behaviour should be 100% like beforeget) did not workshallowReffor increased performance when using reactivityI have tested both the old method (
get) and new method (reactivity) locally, and everything should be OK now.Fixes #5701
Should also address the issue mentioned by @9mm here: #5687 (comment)