Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout Index Routes Don't Have Proper Id #1279

Closed
brandonryan opened this issue Mar 8, 2024 · 3 comments · Fixed by #1280
Closed

Layout Index Routes Don't Have Proper Id #1279

brandonryan opened this issue Mar 8, 2024 · 3 comments · Fixed by #1280

Comments

@brandonryan
Copy link

Describe the bug

Follow up of #1150.

Something in this changes caused the route id's to get a bit strange. Also causing confusion in dev tools

File Tree:
311319082-2ee794e2-c133-4664-91c5-3d96ea2abfb6

Router Dev Tools:
311318390-d35612a4-0c8e-4a83-8425-6ec365121c90
311319423-0459a078-c5d5-439e-87c8-69fd418b838e

Your Example Website or App

N/A

Steps to Reproduce the Bug or Issue

Create project as referenced above

Expected behavior

I'm not exactly sure what the route Id should be but im pretty sure the layout should come before the second /auth

Screenshots or Videos

No response

Platform

  • OS: Windows
  • Browser: Firefox
  • Version: 1.19.2

Additional context

No response

@schiller-manuel
Copy link
Contributor

cc @SeanCassiere

@SeanCassiere
Copy link
Member

SeanCassiere commented Mar 8, 2024

I've fixed this locally. Will do some more testing and open a PR if all works as expected.

Edit:
For reference, the id of the layout route should be /auth/_layout not /auth/auth/_layout.

@SeanCassiere
Copy link
Member

@brandonryan this should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants