Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(experimental_createQueryPersister): return more utilities, rename persister #8062

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(experimental_createQueryPersister): return more utilities, rename persister #8062

wants to merge 1 commit into from
+185 −89

Conversation

DamianOsipiuk
Copy link
Contributor

TODO:

  • docs
  • tests
  • potential setup function to patch queryClient

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 16, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 33ff831. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 16, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8062

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8062

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8062

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8062

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8062

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8062

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8062

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8062

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8062

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8062

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8062

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8062

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8062

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8062

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8062

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8062

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8062

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8062

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8062

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8062

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8062

commit: 33ff831

@DamianOsipiuk DamianOsipiuk force-pushed the do/persister-client-set-get branch from 95dad65 to 33ff831 Compare December 6, 2024 21:39
@github-actions github-actions bot added documentation Improvements or additions to documentation package: react-query labels Dec 6, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 62.71186% with 22 lines in your changes missing coverage. Please review.

Project coverage is 74.35%. Comparing base (32d7189) to head (33ff831).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8062       +/-   ##
===========================================
+ Coverage   46.10%   74.35%   +28.24%     
===========================================
  Files         200       36      -164     
  Lines        7500      620     -6880     
  Branches     1709      164     -1545     
===========================================
- Hits         3458      461     -2997     
+ Misses       3667      132     -3535     
+ Partials      375       27      -348
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core 52.98% <62.71%> (-4.75%) ⬇️
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.54% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation package: query-persist-client-core package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DamianOsipiuk