Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-query): remove placeholderData from suspense query #6973

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

HJZzzzz
Copy link
Contributor

@HJZzzzz HJZzzzz commented Feb 25, 2024

No description provided.

Copy link

vercel bot commented Feb 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 6:21am

Copy link

codesandbox-ci bot commented Feb 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 567736c:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. could you please add a test for your use-case, where placeholderData is set globally ?

Copy link

nx-cloud bot commented Feb 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 567736c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3

Sent with 💌 from NxCloud.

@HJZzzzz
Copy link
Contributor Author

HJZzzzz commented Feb 26, 2024

thanks. could you please add a test for your use-case, where placeholderData is set globally ?

yeap, added two test cases for suspense query & queries

@TkDodo
Copy link
Collaborator

TkDodo commented Feb 26, 2024

there are some issues on formatting and types

@HJZzzzz
Copy link
Contributor Author

HJZzzzz commented Feb 26, 2024

there are some issues on formatting and types

Fixed the formatting and types.

But the useMutationState test passed in my local.
Idk why it failed in ci.

@TkDodo
Copy link
Collaborator

TkDodo commented Feb 26, 2024

there are still formatting issues

@HJZzzzz
Copy link
Contributor Author

HJZzzzz commented Feb 27, 2024

there are still formatting issues

Revised again.

But the failing tests(useMutation & useMutationState) are not related with the code i changed. And from what i see the test passed in my local?
Do you have any ideas why its failing in CI?
Screenshot 2024-02-27 at 10 06 36 AM
Screenshot 2024-02-27 at 10 08 39 AM

@TkDodo
Copy link
Collaborator

TkDodo commented Feb 27, 2024

Do you have any ideas why its failing in CI?

flaky tests, ignore it

@HJZzzzz
Copy link
Contributor Author

HJZzzzz commented Feb 27, 2024

Do you have any ideas why its failing in CI?

flaky tests, ignore it

I see. Are there any other things i need to revise?

@TkDodo TkDodo merged commit d82c83e into TanStack:main Feb 27, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants