-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-query): remove placeholderData from suspense query #6973
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 567736c:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. could you please add a test for your use-case, where placeholderData
is set globally ?
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 567736c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
yeap, added two test cases for suspense query & queries |
there are some issues on formatting and types |
Fixed the formatting and types. But the useMutationState test passed in my local. |
there are still formatting issues |
flaky tests, ignore it |
I see. Are there any other things i need to revise? |
No description provided.