-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query-devtools): Add picture-in-picture mode #6931
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit de29488. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit de29488:
|
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #6931 +/- ##
==========================================
- Coverage 42.11% 41.37% -0.74%
==========================================
Files 180 180
Lines 7060 7186 +126
Branches 1422 1449 +27
==========================================
Hits 2973 2973
- Misses 3725 3831 +106
- Partials 362 382 +20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ardeora This is really cool! I'd just wish for the detached devtools window to not revert back to default mode as soon as I reload the page. Is that possible? |
Hello! This is a great suggestion. I tried implementing something similar but ran into issues. I would love to hear your thoughts or suggestions if you have any feedback on how we can approach this
|
The state of the popup (id, size, position, etc.) could be remembered in local storage. Then the main window could read and somehow re-bind/re-attach/grab the existing popup via the stored id and re-size, re-position it. I'm not sure how can a window get a handle on an existing popup... I'll have to check. |
Okay amazing! I think I have figured it out. Will open a PR soon. Also thank you so much for helping out! |
Add picture-in-picture view to the query devtools.
This allows the devtools to be detached from the main page and open inside a popup. The components are mounted through a portal onto the new window and all interactions work as expected
Here is a screen recording of the feature in play:
Untitled.mov