Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup code-coverage #2834

Closed
TkDodo opened this issue Oct 27, 2021 · 2 comments · Fixed by #2894
Closed

setup code-coverage #2834

TkDodo opened this issue Oct 27, 2021 · 2 comments · Fixed by #2894
Labels
help wanted Extra attention is needed released

Comments

@TkDodo
Copy link
Collaborator

TkDodo commented Oct 27, 2021

setup a bot that reports code-coverage on PRs. I think https://about.codecov.io/ looks good (free for open source), but feel free to analyze. Maybe we need Tanner for installing the github app (in case of codecov: https://github.com/apps/codecov)

Ideally, I would like to see a failing pipeline if code coverage decreases with a PR, because it means that something has been added / changed that is not covered by tests (which would be a requirement for PRs)
@TkDodo TkDodo added the help wanted Extra attention is needed label Oct 27, 2021
@TanStack TanStack deleted a comment from jan-dh Oct 27, 2021
@TkDodo
Copy link
Collaborator Author

TkDodo commented Oct 27, 2021

codecov/codecov-action#29

@prateek3255 prateek3255 mentioned this issue Nov 6, 2021
Merged
@tannerlinsley
Copy link
Collaborator

🎉 This issue has been resolved in version 3.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add code coverage report
2 participants
@TkDodo @tannerlinsley