Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New QR code spam banner too big + re-appears when previously dismissed #2242

Open
adamlui opened this issue Nov 13, 2024 · 11 comments
Open

New QR code spam banner too big + re-appears when previously dismissed #2242

adamlui opened this issue Nov 13, 2024 · 11 comments

Comments

@adamlui
Copy link

adamlui commented Nov 13, 2024

image

Expected Behavior

QR spam to be porportional to menu items and not re-appear post-dismissal

Actual Behavior

It is bulky and awkward, last re-appearance was today on TM auto-update (2024-10-29 ver)

Specifications

  • Firefox: 132.0.1
  • TM: 5.3.2
  • OS: Win10

Also most mobile browsers don't support Chrome extensions so if QR code leads to CWS listing, the Install button will be disabled most of the time (instead, if you must spam, link to a page of supported browsers, that's the biggest obstacle users must overcome, then they will search for TM already so QR code is not useful)

@adamlui
Copy link
Author

adamlui commented Nov 13, 2024

Also I recall testing mobile browsers that simply don't like TM (e.g. popular Kiwi) even with Dev Mode on, but work with other managers, so your priority should be build a list of TM-friendly browsers for the recommendation page

@adamlui
Copy link
Author

adamlui commented Nov 13, 2024

The ones that were confirmed working last I tested were:

(but non-CWS vers weren't updated to MV3 yet, so they may all not work now)

@derjanb
Copy link
Member

derjanb commented Nov 26, 2024

QR spam to be proportional to menu items and not re-appear post-dismissal

Will be fixed...

so if QR code leads to CWS listing, the Install button will be disabled most of the time (instead, if you must spam, link to a page of supported browsers, that's the biggest obstacle users must overcome, then they will search for TM already so QR code is not useful)

Scanning the QR code (with FF icon) should lead you to Firefox's play store entry or Tampermonkey (at AMO) if the link is opened in Firefox Android.

@derjanb
Copy link
Member

derjanb commented Nov 26, 2024

Also I recall testing mobile browsers that simply don't like TM (e.g. popular Kiwi) even with Dev Mode on

#2055

@derjanb derjanb added this to the 5.4 milestone Nov 26, 2024
@derjanb
Copy link
Member

derjanb commented Nov 26, 2024

not re-appear post-dismissal

It should not re-appear unless your browser profile is broken and can't save new data. You can test this by modifying a script and then restart FF. If the changes don't persist, then TM can't save any change anymore.

@adamlui
Copy link
Author

adamlui commented Nov 27, 2024

Scanning the QR code (with FF icon) should lead you to Firefox's play store entry or Tampermonkey (at AMO) if the link is opened in Firefox Android.

I'm saying Chrome users if led to CWS listing will not find it useful since it will not enable Install

#2055

I don't recall ever getting MV3 TM to work in a mobile browser that supported Chrome extensions w/ Dev Mode on but other managers worked, so to prevent losing mobile market share you should try to work around the issue like your competition

It should not re-appear unless your browser profile is broken and can't save new data. You can test this by modifying a script and then restart FF. If the changes don't persist, then TM can't save any change anymore.

Script mods are honored but next time if it happens I'll show a screenshot

@derjanb
Copy link
Member

derjanb commented Nov 27, 2024

I'm saying Chrome users if led to CWS listing will not find it useful since it will not enable Install

They will be forwarded to MS Edge at the play store. I worked with Microsoft and when installing Edge via this link, then Tampermonkey will be pre-installed.

next time if it happens I'll show a screenshot

Please check then the output of this command as well.

chrome.storage.local.get(['#misc_configglobal_hints.items'], e => console.log(e))

@derjanb
Copy link
Member

derjanb commented Nov 27, 2024

Should be fixed at 5.3.6221 (crx|xpi in review)

@adamlui
Copy link
Author

adamlui commented Nov 28, 2024

They will be forwarded to MS Edge at the play store. I worked with Microsoft and when installing Edge via this link, then Tampermonkey will be pre-installed.

I just opened Edge w/ TM installed and it doesn't work though (tapping script install link on GF leads to native download prompt instead, then visiting matched site shows nothing is affected)

My scripts have hundreds of thousands of users and I recommend other managers for Android use because of this.

Again, you should just copy how they work around the Chrome issues if you want a piece of their growing Android mobile market share (also when streaming text response from AI, TM crashes a lot of my users' browsers vs. your competition like VM and SC don't)

Please check then the output of this command as well.

chrome.storage.local.get(['#misc_configglobal_hints.items'], e => console.log(e))

chrome APIs don't work from console + storage keys are sandboxed to the extension calling it, so I would have to edit your extension's source code to successfully view this log unfortunately (but I recommend hide the spam outright until you get Android working right)

@adamlui
Copy link
Author

adamlui commented Nov 28, 2024

I may seem like a pesky annoyance but I have nothing against you, I simply raise issues as I experience them as they affect my many users too, also the fact your competitors who aren't even commercialized like yours rarely give my users any problems is why I recommend TM less and less these days (even as my first manager over 10 years ago)

@adamlui
Copy link
Author

adamlui commented Nov 28, 2024

Also a co-advisor of Mozilla's Community Advisory Board I'm on (we select/review FF add-ons nominated for Recommended badge) just nominated your competitor VM, specifically citing its superiority to TM... so you should reflect on why users are increasingly preferring other managers over yours (even though yours is so old thus should be most stable), then maybe follow my advice about copy them back (after fixing the bugs & issues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants