Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Button ripple effect optional #3

Open
Temzasse opened this issue Nov 10, 2017 · 1 comment
Open

Make Button ripple effect optional #3

Temzasse opened this issue Nov 10, 2017 · 1 comment
Assignees
@Temzasse

Comments

@Temzasse
Copy link
Collaborator

Add a ripple prop that defaults to true.

The ripple effect is applied to the ButtonContent styled component so we could just make two components instead: normal ButtonContent and ButtonContentRipple.

Then we can just render one of them based on the ripple prop.
@Temzasse Temzasse self-assigned this Nov 10, 2017
@aewing
Copy link

aewing commented May 9, 2018

I like the HoC approach to the ripple, personally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Temzasse Temzasse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aewing @Temzasse