From b3ca82774d494f5acdb6c51facc6f79894cc1a4d Mon Sep 17 00:00:00 2001 From: Franco Nieddu Date: Mon, 18 Dec 2023 14:24:15 +0100 Subject: [PATCH] fix: removed upscaling power of 2 during component cost metric --- .../components/component_manifest_utilities.hpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mlir-assigner/include/mlir-assigner/components/component_manifest_utilities.hpp b/mlir-assigner/include/mlir-assigner/components/component_manifest_utilities.hpp index 32b6c33..423ae46 100644 --- a/mlir-assigner/include/mlir-assigner/components/component_manifest_utilities.hpp +++ b/mlir-assigner/include/mlir-assigner/components/component_manifest_utilities.hpp @@ -65,10 +65,11 @@ namespace nil { for (auto it = witness_amount_ptr->begin(); it != witness_amount_ptr->end(); it++) { const auto witness_amount = *it; const auto rows_amount = ComponentType::get_rows_amount(witness_amount, args...); - const auto total_amount_rows_power_two = std::pow(2, std::ceil(std::log2(rows_amount))); + //TACEO_TODO clarify this "improved cost metric" + //const auto total_amount_rows_power_two = std::pow(2, std::ceil(std::log2(rows_amount))); const auto total_amount_of_gates = ComponentType::get_gate_manifest(witness_amount, args...).get_gates_amount(); - values.emplace_back(witness_amount, total_amount_rows_power_two + total_amount_of_gates); + values.emplace_back(witness_amount, rows_amount + total_amount_of_gates); } ASSERT(values.size() > 0); return values; @@ -90,4 +91,4 @@ namespace nil { } // namespace blueprint } // namespace nil -#endif // CRYPTO3_ASSIGNER_COMPONENT_MANIFEST_UTILITIES_HPP \ No newline at end of file +#endif // CRYPTO3_ASSIGNER_COMPONENT_MANIFEST_UTILITIES_HPP