-
-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints for the (Python) codebase. #1464
Comments
Sure, I'd support seeing type hints added where useful. It'll be a lot of work, of course, so it's fine if the transition is gradual, like a lot of refactoring work we've done on the Tabbycat code base. |
@teymour-aldridge still intend to do this? If not I'd be happy to begin a bit of work on this. |
@daankoning Sorry I haven't had a chance to reply sooner. You're welcome to work on this if you're particularly interested in it, but I should say, I think there are much more egregious areas of technical debt in Tabbycat than type hints, examples:
Happy to discuss what you're interested in! I just wanted to say it's probably not the most pressing thing on our backlog. |
Oh thats fine too. I'll have a look at some of those as well :) |
One thing I think would make it substantially easier to refactor code and catch bugs which aren't possible to catch otherwise. In addition, having types makes it possible to use the wealth of code analysis tools which are out there.
I imagine for the Javascript stuff, Flow or Typescript could be used.
I'd be happy to work on this.
The text was updated successfully, but these errors were encountered: