From f9fa86a0fc4b7ff65e85a40da7b0a1b1f8321841 Mon Sep 17 00:00:00 2001
From: Torben Hansen <derhansen@gmail.com>
Date: Sun, 14 Aug 2022 07:54:45 +0200
Subject: [PATCH] [TASK] Use strict comparison in BackendUserRepository
Since the demand object already uses strict types, it
is safe to use strict comparison when properties of the
demand object are used as operand.
Resolves: #98141
Releases: main
Change-Id: I6741c022f9d382416be6cab034d793fedfa35477
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75441
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
---
Classes/Domain/Repository/BackendUserRepository.php | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Classes/Domain/Repository/BackendUserRepository.php b/Classes/Domain/Repository/BackendUserRepository.php
index 32feb04..12145cd 100644
--- a/Classes/Domain/Repository/BackendUserRepository.php
+++ b/Classes/Domain/Repository/BackendUserRepository.php
@@ -77,27 +77,27 @@ public function findDemanded(Demand $demand)
}
}
// Only display admin users
- if ($demand->getUserType() == Demand::USERTYPE_ADMINONLY) {
+ if ($demand->getUserType() === Demand::USERTYPE_ADMINONLY) {
$constraints[] = $query->equals('admin', 1);
}
// Only display non-admin users
- if ($demand->getUserType() == Demand::USERTYPE_USERONLY) {
+ if ($demand->getUserType() === Demand::USERTYPE_USERONLY) {
$constraints[] = $query->equals('admin', 0);
}
// Only display active users
- if ($demand->getStatus() == Demand::STATUS_ACTIVE) {
+ if ($demand->getStatus() === Demand::STATUS_ACTIVE) {
$constraints[] = $query->equals('disable', 0);
}
// Only display in-active users
- if ($demand->getStatus() == Demand::STATUS_INACTIVE) {
+ if ($demand->getStatus() === Demand::STATUS_INACTIVE) {
$constraints[] = $query->equals('disable', 1);
}
// Not logged in before
- if ($demand->getLogins() == Demand::LOGIN_NONE) {
+ if ($demand->getLogins() === Demand::LOGIN_NONE) {
$constraints[] = $query->equals('lastlogin', 0);
}
// At least one login
- if ($demand->getLogins() == Demand::LOGIN_SOME) {
+ if ($demand->getLogins() === Demand::LOGIN_SOME) {
$constraints[] = $query->logicalNot($query->equals('lastlogin', 0));
}
// In backend user group