Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set device to unknown when turn_on/turn_off returns false #388

Open
TWilkin opened this issue Jul 8, 2023 · 0 comments
Open

Set device to unknown when turn_on/turn_off returns false #388

TWilkin opened this issue Jul 8, 2023 · 0 comments
Labels
bug Something isn't working energenie-controller Relating to the energenie controller service harmony-controller Relating to the harmony controller service lifx-controller Relating to the LIFX controller service network-controller Relating to the network controller service virtual-controller Relating to the virtual controller service zigbee-controller Relating to the ZigBee controller service
Milestone

Comments

@TWilkin
Copy link
Owner

TWilkin commented Jul 8, 2023

Already happens if the call throws, but not if the device says the state update failed.

Would be good if this mechanism happened for additional state, as a device could be waiting for a response which will never happen so it times out i.e. changing to a scene for a device that is off.

@TWilkin TWilkin added bug Something isn't working energenie-controller Relating to the energenie controller service zigbee-controller Relating to the ZigBee controller service virtual-controller Relating to the virtual controller service harmony-controller Relating to the harmony controller service lifx-controller Relating to the LIFX controller service node-controller Relating to the node controller service network-controller Relating to the network controller service labels Jul 8, 2023
@TWilkin TWilkin added this to the Scenes milestone Jul 8, 2023
@TWilkin TWilkin removed the node-controller Relating to the node controller service label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working energenie-controller Relating to the energenie controller service harmony-controller Relating to the harmony controller service lifx-controller Relating to the LIFX controller service network-controller Relating to the network controller service virtual-controller Relating to the virtual controller service zigbee-controller Relating to the ZigBee controller service
Projects
None yet
Development

No branches or pull requests

1 participant