Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues with the app. #11

Open
CaffeineOnIce opened this issue Dec 3, 2024 · 9 comments
Open

Some issues with the app. #11

CaffeineOnIce opened this issue Dec 3, 2024 · 9 comments

Comments

@CaffeineOnIce
Copy link

Nearly perfect. But extremely rough around the edges.

  1. Animations are jittery and not smooth at all. Feels very choppy.
  2. Lag while scrolling kind of makes it unusable. I know it's a composable issue, but it kinda makes the entire thing annoying to use after a while.
  3. Icons for the folders is kind of blocky and square. Doesn't quite fit in with the rest of the UI.
  4. No Play Next option for a certain song.

Other than that, pretty good.

@TJYSunset
Copy link
Owner

TJYSunset commented Dec 3, 2024

Animations are jittery and not smooth at all. Feels very choppy.

Exact which animations? I can only observe lags while rapidly swiping between tracks and when dragging up the player, both of which are noticeable but not prominent.

These two are again Google problems. I probably shouldn't have use this "next-gen" POS framework Google advocated.

Lag while scrolling kind of makes it unusable

If you are talking about the lag on initial scrolling (which goes away on consecutive swipes), actually it can be entirely prevented by removing scrollbars altogether. Should I add an option to remove scrollbars as a temporary fix?

Icons for the folders is kind of blocky and square

Aren't all the other open source players using exactly the same icon set from Google?

No Play Next option for a certain song

Noted, I'll add that in the next release.

@CaffeineOnIce
Copy link
Author

CaffeineOnIce commented Dec 3, 2024

Exact which animations? I can only observe lags while rapidly swiping between tracks and when dragging up the player, both of which are noticeable but not prominent.

These two are again Google problems. I probably shouldn't have use this "next-gen" POS framework Google advocated.

yeah, those lags I'm talking about. It's a bit, hmmm... unrefined, I'd say. Been using a Phonograph fork, Vinyl, for ages now. So, it's second nature for me to compare.

If you are talking about the lag on initial scrolling (which goes away on consecutive swipes), actually it can be entirely prevented by removing scrollbars altogether. Should I add an option to remove scrollbars as a temporary fix?

Not a bad idea, actually. But I dunno, some people may frown upon it.

Screenshot_20241203_150928_Phocid
And for the icons, if possible, lose the white square background and make the icon, simply see through. The square really throws the UI off, actually.

@TJYSunset
Copy link
Owner

Please open separate issues for each topic next time, or use discussions for unorganized stuff.


I can think of ways to "fix" these, but they'll be complicated mush of spaghetti that make the entire codebase unmaintainable.

Somehow found a fix for the scrollbar problem after brute forcing through one million possible combinations. See #8 (comment)

And for the icons, if possible, lose the white square background and make the icon, simply see through.

I've tried that approach before, and it looked ugly as hell. Maybe inverting the background's color in dark theme would make it slightly better?

Addded in a447425. The above build also contains this addition.

@CaffeineOnIce
Copy link
Author

oh. Did you use 'Folder' or 'Folder Open' from the icons?

@CaffeineOnIce
Copy link
Author

Oh and, I mentioned in that issue thread that the lag is not entirely gone, btw. Might detract newer users from using it.

@TJYSunset
Copy link
Owner

Icon mockup

(Photoshopped mockup but mostly what it'd look like in practice)

Personally I like the "colored icon on white square" better than any of the three, but that's just me.

@CaffeineOnIce
Copy link
Author

This one does look clean, ngl. Personally, I like this one better. But if you intend to keep the older square, just round off the edges. Mat3 is kinda round in terms of edges.

@TJYSunset
Copy link
Owner

TJYSunset commented Dec 5, 2024

But if you intend to keep the older square, just round off the edges

Added option to use rounded square or circle in 76e0488

Mat3 is kinda round in terms of edges.

Yes, but I also decided to not crop album covers by default like the old Phonograph didn't. I hated that behavior in other apps I've tried.

For the icon-without-background option, there's a problem not present in the original Phonograph: the playlist and folder tabs now support grid view. How would that look like in grid view?

@CaffeineOnIce
Copy link
Author

yeah. grid view would look off. yeah, that'll be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants