-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some issues with the app. #11
Comments
Exact which animations? I can only observe lags while rapidly swiping between tracks and when dragging up the player, both of which are noticeable but not prominent. These two are again Google problems. I probably shouldn't have use this "next-gen" POS framework Google advocated.
If you are talking about the lag on initial scrolling (which goes away on consecutive swipes), actually it can be entirely prevented by removing scrollbars altogether. Should I add an option to remove scrollbars as a temporary fix?
Aren't all the other open source players using exactly the same icon set from Google?
Noted, I'll add that in the next release. |
Please open separate issues for each topic next time, or use discussions for unorganized stuff. I can think of ways to "fix" these, but they'll be complicated mush of spaghetti that make the entire codebase unmaintainable. Somehow found a fix for the scrollbar problem after brute forcing through one million possible combinations. See #8 (comment)
I've tried that approach before, and it looked ugly as hell. Maybe inverting the background's color in dark theme would make it slightly better? Addded in a447425. The above build also contains this addition. |
oh. Did you use 'Folder' or 'Folder Open' from the icons? |
Oh and, I mentioned in that issue thread that the lag is not entirely gone, btw. Might detract newer users from using it. |
This one does look clean, ngl. Personally, I like this one better. But if you intend to keep the older square, just round off the edges. Mat3 is kinda round in terms of edges. |
Added option to use rounded square or circle in 76e0488
Yes, but I also decided to not crop album covers by default like the old Phonograph didn't. I hated that behavior in other apps I've tried. For the icon-without-background option, there's a problem not present in the original Phonograph: the playlist and folder tabs now support grid view. How would that look like in grid view? |
yeah. grid view would look off. yeah, that'll be a problem. |
Nearly perfect. But extremely rough around the edges.
Other than that, pretty good.
The text was updated successfully, but these errors were encountered: