Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fjern brug af reflection og andre punkter hvis nødvendigt #37

Open
TFSMads opened this issue Jul 29, 2024 · 3 comments
Open

Fjern brug af reflection og andre punkter hvis nødvendigt #37

TFSMads opened this issue Jul 29, 2024 · 3 comments
Assignees
@TFSMads
Labels
enhancement New feature or request priority: medium

Comments

@TFSMads
Copy link
Owner

TFSMads commented Jul 29, 2024

pga. labymod 4 guidelines.

image
@TFSMads TFSMads added enhancement New feature or request priority: medium labels Jul 29, 2024
@TFSMads TFSMads changed the title Fjern brug af reflection Fjern brug af reflection og andre punkter hvis nødvendigt Jul 29, 2024
@TFSMads
Copy link
Owner Author

TFSMads commented Jul 29, 2024

image
image

@TFSMads TFSMads self-assigned this Aug 10, 2024
@TFSMads
Copy link
Owner Author

TFSMads commented Dec 5, 2024 •
edited
Loading

Review comment fra labymod (ting der skal fixes før den kan komme på addon store):

  • - 1. Do not use reflection
  • - 2. Use our Activity System for screens
  • - 3. Use our Widget Editor (Bruges allerede - men fjern gammel system)
  • - 4. Use our config & setting system
  • - 5. Don't wrap our events in your own event system - use our events directly
  • - 6. Dont use Legacy Color Codes

@TFSMads TFSMads mentioned this issue Dec 16, 2024
Merged
@TFSMads
Copy link
Owner Author

TFSMads commented Dec 16, 2024 •
edited
Loading

  • Tilføjelse til 5. punkt, skift til kun at bruge labymod event system til custom events hvis muligt

This was referenced Dec 16, 2024
Merged
Merged
Merged
@TFSMads TFSMads mentioned this issue Dec 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TFSMads TFSMads

Labels
enhancement New feature or request priority: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TFSMads