Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fractional item prices (Price per scrap) #414

Open
Bonfire opened this issue Mar 4, 2021 · 2 comments
Open

Fractional item prices (Price per scrap) #414

Bonfire opened this issue Mar 4, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Bonfire
Copy link
Member

Bonfire commented Mar 4, 2021

Is your feature request related to a problem? Please describe.
Currently, the absolute lowest price an item that is traded to the bot can have is half of one scrap (0.05 ref). This means that for extremely low priced items, the minimum value given to the item is half of a scrap (which may be incorrect).

Describe the feature you'd like
I propose a new feature allowing items to be valued or priced "fractionally". These prices would only be used for manual pricing.

One method of doing so is allowing items to be priced at any value greater than zero (for example, allowing a price of 0.01 ref or 0.025 ref). Though this requires the bot admin to do some mental calculus to actually figure out what the price of an item should be. Requiring the admin to take fractions of a fraction I think may be a little cumbersome. While it is one solution, I do not think it is the best solution and may result in very complex pricing for some items.

The second method of doing so would be to value items on a "per scrap" basis. That is to say, allowing the user to specify "this item is worth 10 per scrap" and conversely, "one scrap is worth 10 of this item". Because these items would all be less than a scrap, it would make sense to use scrap as a reference point. Some example listing parameters I could propose are buy.perScrap and sell.perScrap, where if the user inputs buy.perScrap=25, the bot would buy the item at the price of "25 per one scrap".

There of course may be better ways of implementing this, but those two solutions come to mind.

Describe alternatives you've considered
Pricing everything at a minimum of 0.05 refined (which may inaccurately represent an item's actual price).

Got any bounty as a reward for anyone fulfills your request?
N/A

Additional context
Note that in its current state, if an admin attempts to change an items price to anything less than or equal to 0.01 ref, the bot will value it at 0.00 refined.

@Bonfire Bonfire added the enhancement New feature or request label Mar 4, 2021
@idinium96
Copy link
Member

Thanks, @Bonfire.
I see this is kinda "hard" to implement tbh.

@Bonfire
Copy link
Member Author

Bonfire commented Mar 4, 2021

Thanks, @Bonfire.
I see this is kinda "hard" to implement tbh.

You are correct. I may offer a bounty as time goes on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants