From ade736dca30566e469d7af18b47d76f7ac8bf73c Mon Sep 17 00:00:00 2001
From: Ridhwana <Ridhwana.Khan16@gmail.com>
Date: Wed, 28 Sep 2022 19:21:38 +0200
Subject: [PATCH] Refactor: no need to pass through the ahoy event name
 dynamically. (#18498)

* refactor: the name does not need to be passed through dynamically

* refactor: the name does not need to be passed through dynamically

* chore: remove name from the js doc
---
 app/javascript/packs/articlePage.jsx          |  2 +-
 app/javascript/packs/base.jsx                 | 11 ++---------
 app/javascript/packs/homePage.jsx             |  7 ++-----
 app/javascript/utilities/ahoy/trackEvents.jsx | 10 ++++------
 4 files changed, 9 insertions(+), 21 deletions(-)

diff --git a/app/javascript/packs/articlePage.jsx b/app/javascript/packs/articlePage.jsx
index f114c6326d266..75de943cd5ca9 100644
--- a/app/javascript/packs/articlePage.jsx
+++ b/app/javascript/packs/articlePage.jsx
@@ -160,5 +160,5 @@ targetNode && embedGists(targetNode);
 
 initializeUserSubscriptionLiquidTagContent();
 // Temporary Ahoy Stats for comment section clicks on controls
-trackCommentClicks('comments', 'Comment section click');
+trackCommentClicks('comments');
 trackCommentsSectionDisplayed();
diff --git a/app/javascript/packs/base.jsx b/app/javascript/packs/base.jsx
index 82624aa3a53c9..d1cd4a31226cc 100644
--- a/app/javascript/packs/base.jsx
+++ b/app/javascript/packs/base.jsx
@@ -125,12 +125,5 @@ if (document.location.pathname === '/admin/creator_settings/new') {
   loadCreatorSettings();
 }
 
-trackCreateAccountClicks(
-  'authentication-hamburger-actions',
-  'Clicked on Create Account',
-);
-
-trackCreateAccountClicks(
-  'authentication-top-nav-actions',
-  'Clicked on Create Account',
-);
+trackCreateAccountClicks('authentication-hamburger-actions');
+trackCreateAccountClicks('authentication-top-nav-actions');
diff --git a/app/javascript/packs/homePage.jsx b/app/javascript/packs/homePage.jsx
index 449833d4d75d2..d6ee1b4bb2ca4 100644
--- a/app/javascript/packs/homePage.jsx
+++ b/app/javascript/packs/homePage.jsx
@@ -129,8 +129,5 @@ InstantClick.on('change', () => {
 });
 InstantClick.init();
 
-trackCreateAccountClicks('sidebar-wrapper-left', 'Clicked on Create Account');
-trackCreateAccountClicks(
-  'authentication-feed-actions',
-  'Clicked on Create Account',
-);
+trackCreateAccountClicks('sidebar-wrapper-left');
+trackCreateAccountClicks('authentication-feed-actions');
diff --git a/app/javascript/utilities/ahoy/trackEvents.jsx b/app/javascript/utilities/ahoy/trackEvents.jsx
index 51ec9cfd9148a..531aec35d682c 100644
--- a/app/javascript/utilities/ahoy/trackEvents.jsx
+++ b/app/javascript/utilities/ahoy/trackEvents.jsx
@@ -4,16 +4,15 @@ import ahoy from 'ahoy.js';
 // * passed in element.
 // *
 // * @param {string} elementId A unique identifier to identify the element that is being tracked
-// * @param {string} name The name of the event
 // */
-export function trackCommentClicks(elementId, name) {
+export function trackCommentClicks(elementId) {
   document
     .getElementById(elementId)
     ?.addEventListener('click', ({ target }) => {
       const relevantNode = getTrackingNode(target, '[data-tracking-name]');
 
       if (relevantNode) {
-        ahoy.track(name, {
+        ahoy.track('Comment section click', {
           page: location.href,
           element: relevantNode.dataset?.trackingName,
         });
@@ -25,15 +24,14 @@ export function trackCommentClicks(elementId, name) {
 // * passed in element.
 // *
 // * @param {string} elementId A unique identifier to identify the element that is being tracked
-// * @param {string} name The name of the event
 // */
-export function trackCreateAccountClicks(elementId, name) {
+export function trackCreateAccountClicks(elementId) {
   document
     .getElementById(elementId)
     ?.addEventListener('click', ({ target }) => {
       const relevantNode = getTrackingNode(target, '[data-tracking-id]');
       if (relevantNode) {
-        ahoy.track(name, {
+        ahoy.track('Clicked on Create Account', {
           version: 0.1,
           page: location.href,
           source: relevantNode.dataset?.trackingSource,