Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(edit-profile): Too much restriction on display name #1423

Open
WaDadidou opened this issue Nov 25, 2024 · 3 comments
Open

bug(edit-profile): Too much restriction on display name #1423

WaDadidou opened this issue Nov 25, 2024 · 3 comments
Labels
bug Something isn't working UPP

Comments

@WaDadidou
Copy link
Collaborator

We can mint a Name using the TNS feature, and put accents on the public name.
But in UPP, we have these restrictions.
Here, I modified the bio, but I can't validate because the public name has an accent :(

Image
Image

@WaDadidou WaDadidou added bug Something isn't working UPP labels Nov 25, 2024
@n0izn0iz
Copy link
Collaborator

n0izn0iz commented Nov 26, 2024

There's not much reason to have any restriction here, maybe prevent hacky charpoints but otherwise it should be able to use arabic, cyrillic, chinese, emojis, etc...

@clegirar
Copy link
Collaborator

clegirar commented Dec 3, 2024

Okay i digged a little for that, and i propose to have the modal from TNS for the Edit Profile button in the User Profile.

TNS Modal is named Edit Profile btw, so i think it's okay to just navigate to this modal instead to have two "same" modals, it means code repetition etc. (and on TNS modal we don't have any restrictions about accents etc.)

Wdyt ?

@n0izn0iz
Copy link
Collaborator

n0izn0iz commented Dec 3, 2024

the modal in upp is the new design with a simple experience and consistency across chains, the tns one is legacy, we just need to remove the restriction in the new one

@n0izn0iz n0izn0iz changed the title bug(tns): Too much restriction on TNS display name bug(edit-profile): Too much restriction on display name Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UPP
Projects
None yet
Development

No branches or pull requests

3 participants