Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refacto(toasts): remove toast "mode" prop #1394

Open
WaDadidou opened this issue Nov 18, 2024 · 0 comments
Open

refacto(toasts): remove toast "mode" prop #1394

WaDadidou opened this issue Nov 18, 2024 · 0 comments
Labels
refacto

Comments

@WaDadidou
Copy link
Collaborator

The mode prop: https://github.com/TERITORI/teritori-dapp/blob/main/packages/context/FeedbacksProvider.tsx#L20

When we call setToast, we have to pass a mandatory prop mode.
But this mode can be set directly in FeedbackProvider, because it depends on the mode, that should be a global setting
@WaDadidou WaDadidou added the enhancement New feature or request label Nov 18, 2024
@WaDadidou WaDadidou changed the title refacto(toasts): remove toast type prop refacto(toasts): remove toast "mode" prop Nov 18, 2024
@WaDadidou WaDadidou added refacto and removed enhancement New feature or request labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refacto
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WaDadidou