Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(feed): AudioNote thumbnail is not shown in MediaPlayerBar #1365

Closed
WaDadidou opened this issue Nov 16, 2024 · 6 comments
Closed

bug(feed): AudioNote thumbnail is not shown in MediaPlayerBar #1365

WaDadidou opened this issue Nov 16, 2024 · 6 comments
Assignees
Labels
bug Something isn't working Social Feed Everything related to the Social Feed

Comments

@WaDadidou
Copy link
Collaborator

image

But it's ok with MusicAudio

image
image

@WaDadidou WaDadidou added bug Something isn't working Social Feed Everything related to the Social Feed labels Nov 16, 2024
@n0izn0iz
Copy link
Collaborator

do we really want audionotes to have thumbnails?

@n0izn0iz
Copy link
Collaborator

an audio note is like a vocal message in a messaging app, I don't think it should have a thumbnail

@WaDadidou
Copy link
Collaborator Author

WaDadidou commented Nov 21, 2024

do we really want audionotes to have thumbnails?

Currently, it can.
But we could remove it yes. I think we should, I don't see an added value :/
If you want to post an image and an audio, you can.
Why sticking an image to the audio ? To express what ?
BUT, we'll always have the default thumbnail in the media player

@zxxma , wdyt ?

image

@n0izn0iz
Copy link
Collaborator

BUT, we'll always have the default thumbnail in the media player

it should show the user avatar in this case IMO

@WaDadidou
Copy link
Collaborator Author

BUT, we'll always have the default thumbnail in the media player

it should show the user avatar in this case IMO

Ah yes yes.
Btw it should be the default thumbnail in the media player

@n0izn0iz
Copy link
Collaborator

closing as won't do, opened #1407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Social Feed Everything related to the Social Feed
Projects
None yet
Development

No branches or pull requests

2 participants