Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(feed): Add thumbnail to Media interface #1351

Open
WaDadidou opened this issue Nov 14, 2024 · 0 comments · May be fixed by #1404
Open

chore(feed): Add thumbnail to Media interface #1351

WaDadidou opened this issue Nov 14, 2024 · 0 comments · May be fixed by #1404
Assignees
@WaDadidou
Labels
refacto Social Feed Everything related to the Social Feed

Comments

@WaDadidou
Copy link
Collaborator

It could be nice to having a thumbnailImage or something directly in the Media interface: https://github.com/TERITORI/teritori-dapp/blob/main/packages/utils/types/mediaPlayer.ts#L1

So, when a media is played and the object Media is set in MediaPlayerProvider, we just have to use this thumbnail instead of deduct it like this: https://github.com/TERITORI/teritori-dapp/blob/main/packages/components/mediaPlayer/MediaNameImage.tsx#L40
@WaDadidou WaDadidou changed the title feat(feed): Add thumbnail to Media interface chore(feed): Add thumbnail to Media interface Nov 16, 2024
@WaDadidou WaDadidou added the Social Feed Everything related to the Social Feed label Nov 16, 2024
@WaDadidou WaDadidou linked a pull request Nov 20, 2024 that will close this issue
Open
@WaDadidou WaDadidou self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WaDadidou WaDadidou

Labels
refacto Social Feed Everything related to the Social Feed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(feed): remove AudioNote thumbnail TERITORI/teritori-dapp
1 participant
@WaDadidou