Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve New Feedback Session Form #12449

Open
alcantaragiubs opened this issue May 24, 2023 · 2 comments · May be fixed by #13185
Open

Improve New Feedback Session Form #12449

alcantaragiubs opened this issue May 24, 2023 · 2 comments · May be fixed by #13185

Comments

@alcantaragiubs
Copy link

At the New Feedback Session form, the fields should have more validations, cause, for example if you don't write anything in the Instructions field, or just send without even trying to write, the New form accepts it and submit.

@weiquu
Copy link
Contributor

weiquu commented May 24, 2023

Hi @alcantaragiubs, could you provide more examples of the fields you are referring to as well as the validations expected?

I took a quick look at the Add New Feedback Session form, and only see 2 places where instructors have to type some sort of input: the session name and the instructions.

For the session name, if the instructor leaves it blank (e.g. "just send without even trying to write"), an error is shown since the session must have a name. For the instructions field, I think it's fine for it to be blank since instructors might not want/need instructions for the session.

@YingxuanT
Copy link

YingxuanT commented Oct 20, 2024

Hi, @alcantaragiubs , I am really interest in this issue, can I try to achieve this feature?

I think this just need to add some validation function in the front end specially the .ts and .html files in path of 'web/app/components/session-edit-form' .
截屏2024-10-20 下午1 11 56

YingxuanT added a commit to YingxuanT/teammates that referenced this issue Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants