Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save all comments when saving responses for all questions #12527

Closed
zhaojj2209 opened this issue Jul 22, 2023 · 9 comments
Closed

Save all comments when saving responses for all questions #12527

zhaojj2209 opened this issue Jul 22, 2023 · 9 comments
Labels
s.NeedsInfo More information is needed from the issue reporter

Comments

@zhaojj2209
Copy link
Contributor

Currently, the "Submit Responses to All Questions" button does not save comments. Given that comments for responses are now allowed for all question types (see #12426), it is all the more important that comments are saved along with the responses.

@zhaojj2209 zhaojj2209 added p.Medium Marginal impact; would like to do if time permits help wanted Moderate difficulty, small localized change; suitable for novice contributors labels Jul 22, 2023
@Saimurugeshwari
Copy link

can I work on this issue.

@jasonqiu212
Copy link
Contributor

Hi @Saimurugeshwari, sure! Feel free to submit a PR for this issue

@undermyumbrella1
Copy link
Contributor

Hi @Saimurugeshwari, may i check if you are working on this issue? if not, i would like to give it a go!

@Saimurugeshwari
Copy link

Hi @ellaella12 , I am still working on this issue, Kind of stuck, I will raise a PR request today or tomorrow, Sorry for the delay.

@dlimyy
Copy link
Contributor

dlimyy commented Aug 23, 2023

Hi, may I check if this issue is currently still being worked on by anyone as I would like to give this issue a try. Thanks!

@domlimm
Copy link
Contributor

domlimm commented Aug 23, 2023

@dlimyy Please go ahead. I don't think @Saimurugeshwari is working on it.

@dlimyy
Copy link
Contributor

dlimyy commented Aug 26, 2023

Hi, I am currently working on this issue and am experiencing some difficulties in replicating the error identified in the issue. I have attempted to click the "Submit Responses to All Questions" button but noticed that the comments were saved in my end instead of being unsaved as stated in the issue(I checked from the instructor's perspective(through view results) and student's perspective). I am wondering if anyone knows the steps that can be taken to replicate the bug. Thanks!

@samuelfangjw samuelfangjw added s.NeedsInfo More information is needed from the issue reporter and removed p.Medium Marginal impact; would like to do if time permits help wanted Moderate difficulty, small localized change; suitable for novice contributors labels Aug 26, 2023
@samuelfangjw
Copy link
Member

I'm not able to replicate this either. @zhaojj2209 could you please help to verify if the issue still occurs on your end?

@zhaojj2209
Copy link
Contributor Author

Sorry for the late response. I can no longer replicate the bug on my end either, will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.NeedsInfo More information is needed from the issue reporter
Projects
None yet
Development

No branches or pull requests

7 participants