diff --git a/.github/workflows/comment-goodfirstissue.yml b/.github/workflows/comment-goodfirstissue.yml new file mode 100644 index 00000000000..97c001be75f --- /dev/null +++ b/.github/workflows/comment-goodfirstissue.yml @@ -0,0 +1,30 @@ +name: Comment on Good First Issue + +on: + issues: + types: + - labeled + +jobs: + comment: + if: github.event.label.name == 'good first issue' + runs-on: ubuntu-latest + + steps: + - name: Add comment + uses: actions/github-script@v6 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + let body = `**Good First Issue - Notes for Contributors** + This issue is for **first-time contributors only**. If you are new to TEAMMATES, feel free to submit a PR for this issue.\n\n` + body += "*Please note that we allow only one `good first issue` per contributor.* If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the `help wanted` tag instead.\n\n" + body += "**We do not assign issues to contributors**. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.\n\n" + body += "**To get started**, do read through our [contributing guidelines](https://teammates.github.io/teammates/contributing-doc.html) carefully, and [set up a development environment on your local machine](https://teammates.github.io/teammates/setting-up.html) before making a PR.\n\n" + body += "If you need any clarifications on our [developer guide](https://teammates.github.io/teammates/index.html), or are facing issues that are not found in our [troubleshooting guide](https://teammates.github.io/teammates/troubleshooting-guide.html), please [post a message in our discussion forum](https://github.com/TEAMMATES/teammates/discussions)." + await github.rest.issues.createComment({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + body, + }) diff --git a/src/web/app/components/panel-chevron/panel-chevron.component.html b/src/web/app/components/panel-chevron/panel-chevron.component.html index 9a924686122..48594557a11 100644 --- a/src/web/app/components/panel-chevron/panel-chevron.component.html +++ b/src/web/app/components/panel-chevron/panel-chevron.component.html @@ -1,4 +1,4 @@ -
+
+ diff --git a/src/web/app/components/panel-chevron/panel-chevron.component.scss b/src/web/app/components/panel-chevron/panel-chevron.component.scss index ee53858661d..a00f6edd589 100644 --- a/src/web/app/components/panel-chevron/panel-chevron.component.scss +++ b/src/web/app/components/panel-chevron/panel-chevron.component.scss @@ -1,4 +1,10 @@ -.chevron { +button.chevron { display: inline-flex; vertical-align: middle; + background-color: inherit; + border-width: 0; +} + +button.chevron:active { + background-color: inherit; } diff --git a/src/web/app/components/question-edit-form/__snapshots__/question-edit-form.component.spec.ts.snap b/src/web/app/components/question-edit-form/__snapshots__/question-edit-form.component.spec.ts.snap index ff17dc5d3f7..22d1fe0b703 100644 --- a/src/web/app/components/question-edit-form/__snapshots__/question-edit-form.component.spec.ts.snap +++ b/src/web/app/components/question-edit-form/__snapshots__/question-edit-form.component.spec.ts.snap @@ -39,13 +39,16 @@ exports[`QuestionEditFormComponent should snap with default view 1`] = ` class="collapse-caret" > -
-
+
+
+
diff --git a/src/web/app/components/question-response-panel/question-response-panel.component.ts b/src/web/app/components/question-response-panel/question-response-panel.component.ts index e1b3a9d6e4c..e44f8a56f55 100644 --- a/src/web/app/components/question-response-panel/question-response-panel.component.ts +++ b/src/web/app/components/question-response-panel/question-response-panel.component.ts @@ -96,6 +96,7 @@ export class QuestionResponsePanelComponent { next: (sessionResults: SessionResults) => { const responses: QuestionOutput = sessionResults.questions[0]; if (responses) { + question.hasResponse = true; question.feedbackQuestion = responses.feedbackQuestion; question.allResponses = responses.allResponses; question.otherResponses = responses.otherResponses; @@ -104,7 +105,7 @@ export class QuestionResponsePanelComponent { question.responsesToSelf = responses.responsesToSelf; question.hasResponseButNotVisibleForPreview = responses.hasResponseButNotVisibleForPreview; question.hasCommentNotVisibleForPreview = responses.hasCommentNotVisibleForPreview; - } else { + } else { question.hasResponse = false; if (question.errorMessage) { this.statusMessageService.showSuccessToast('Question ' diff --git a/src/web/app/components/question-submission-form/question-submission-form.component.html b/src/web/app/components/question-submission-form/question-submission-form.component.html index 069c63a0899..2602f43f081 100644 --- a/src/web/app/components/question-submission-form/question-submission-form.component.html +++ b/src/web/app/components/question-submission-form/question-submission-form.component.html @@ -1,12 +1,12 @@
- +
@@ -214,7 +214,8 @@

Question {{ model.questionNumber }}: {{ mode
diff --git a/src/web/app/components/question-types/question-edit-answer-form/text-question-edit-answer-form.component.html b/src/web/app/components/question-types/question-edit-answer-form/text-question-edit-answer-form.component.html index 3214e968a25..bc9a583b9bf 100644 --- a/src/web/app/components/question-types/question-edit-answer-form/text-question-edit-answer-form.component.html +++ b/src/web/app/components/question-types/question-edit-answer-form/text-question-edit-answer-form.component.html @@ -1,7 +1,7 @@
- +
@@ -109,13 +112,16 @@ exports[`UserNotificationsListComponent should snap when all loaded notification class="card-header-btn-toolbar" > - +

@@ -253,13 +259,16 @@ exports[`UserNotificationsListComponent should snap when it loads the provided n class="card-header-btn-toolbar" > -
-
+
@@ -307,13 +316,16 @@ exports[`UserNotificationsListComponent should snap when it loads the provided n class="card-header-btn-toolbar" > -
-
+
@@ -430,13 +442,16 @@ exports[`UserNotificationsListComponent should snap when it sorts the notificati class="card-header-btn-toolbar" > -
-
+
@@ -484,13 +499,16 @@ exports[`UserNotificationsListComponent should snap when it sorts the notificati class="card-header-btn-toolbar" > -
-
+
@@ -607,13 +625,16 @@ exports[`UserNotificationsListComponent should snap when it sorts the notificati class="card-header-btn-toolbar" > -
-
+
@@ -661,13 +682,16 @@ exports[`UserNotificationsListComponent should snap when it sorts the notificati class="card-header-btn-toolbar" > -
-
+
diff --git a/src/web/app/components/visibility-panel/visibility-panel.component.html b/src/web/app/components/visibility-panel/visibility-panel.component.html index 82957f78264..425928a1cad 100644 --- a/src/web/app/components/visibility-panel/visibility-panel.component.html +++ b/src/web/app/components/visibility-panel/visibility-panel.component.html @@ -24,28 +24,30 @@ - - - - - - - - - - - - +
+
User/Group{{ visibilityControl | visibilityControlName }}
{{ visibilityType | visibilityTypeName }} - -
+ + + + - - -
User/Group{{ visibilityControl | visibilityControlName }}
+ + + + + {{ visibilityType | visibilityTypeName }} + + + + + + + +
This is the visibility hint as seen by the feedback giver:
    diff --git a/src/web/app/pages-instructor/instructor-course-edit-page/copy-instructors-from-other-courses-modal/__snapshots__/copy-instructors-from-other-courses-modal.component.spec.ts.snap b/src/web/app/pages-instructor/instructor-course-edit-page/copy-instructors-from-other-courses-modal/__snapshots__/copy-instructors-from-other-courses-modal.component.spec.ts.snap index cda762a9dbe..f05954210be 100644 --- a/src/web/app/pages-instructor/instructor-course-edit-page/copy-instructors-from-other-courses-modal/__snapshots__/copy-instructors-from-other-courses-modal.component.spec.ts.snap +++ b/src/web/app/pages-instructor/instructor-course-edit-page/copy-instructors-from-other-courses-modal/__snapshots__/copy-instructors-from-other-courses-modal.component.spec.ts.snap @@ -81,13 +81,16 @@ exports[`CopyInstructorsFromOtherCoursesModalComponent should snap when feedback class="card-header-btn-toolbar" > -
    -
    +
@@ -218,13 +221,16 @@ exports[`CopyInstructorsFromOtherCoursesModalComponent should snap when instruct class="card-header-btn-toolbar" > -
-
+
@@ -478,13 +484,16 @@ exports[`CopyInstructorsFromOtherCoursesModalComponent should snap when instruct class="card-header-btn-toolbar" > -
-
+
@@ -612,13 +621,16 @@ exports[`CopyInstructorsFromOtherCoursesModalComponent should snap with courses class="card-header-btn-toolbar" > - + @@ -640,13 +652,16 @@ exports[`CopyInstructorsFromOtherCoursesModalComponent should snap with courses class="card-header-btn-toolbar" > - + diff --git a/src/web/app/pages-instructor/instructor-home-page/__snapshots__/instructor-home-page.component.spec.ts.snap b/src/web/app/pages-instructor/instructor-home-page/__snapshots__/instructor-home-page.component.spec.ts.snap index e003acc07c9..0329d14dff8 100644 --- a/src/web/app/pages-instructor/instructor-home-page/__snapshots__/instructor-home-page.component.spec.ts.snap +++ b/src/web/app/pages-instructor/instructor-home-page/__snapshots__/instructor-home-page.component.spec.ts.snap @@ -269,15 +269,6 @@ exports[`InstructorHomePageComponent should snap with one course with error load > [CS3281]: Thematic Systems I - -
- -
-
+ + + - -
- -
-
+ + + - -
- -
-
+ + + - -
- -
-
@@ -2032,6 +2044,7 @@ exports[`InstructorHomePageComponent should snap with one course with unpopulate aria-expanded="false" class="dropdown-toggle btn btn-primary btn-sm" ngbdropdowntoggle="" + type="button" > Students @@ -2063,6 +2076,7 @@ exports[`InstructorHomePageComponent should snap with one course with unpopulate aria-expanded="false" class="dropdown-toggle btn btn-primary btn-sm" ngbdropdowntoggle="" + type="button" > Instructors @@ -2087,6 +2101,7 @@ exports[`InstructorHomePageComponent should snap with one course with unpopulate aria-expanded="false" class="dropdown-toggle btn btn-primary btn-sm" ngbdropdowntoggle="" + type="button" > Sessions @@ -2111,6 +2126,7 @@ exports[`InstructorHomePageComponent should snap with one course with unpopulate aria-expanded="false" class="dropdown-toggle btn-course btn btn-primary btn-sm" ngbdropdowntoggle="" + type="button" > Course @@ -2151,16 +2167,19 @@ exports[`InstructorHomePageComponent should snap with one course with unpopulate + + + - -
- -
-
+ + + - -
- -
-
-
-
+
- - - - - - - - - - - - + - - - - - - - - - - - - - - - - - - - -
- User/Group - - Can see answer - - Can see giver's name - - Can see recipient's name -
- +
- Recipient(s) - - - - - - - - -
- + - Giver's Team Members - - - - - - - - -
- + - Other students - - - - - - - - -
- + - Instructors - - - - - - - - -
+ Can see recipient's name + + + + + + + + Recipient(s) + + + + + + + + + + + + + + + + Giver's Team Members + + + + + + + + + + + + + + + + Other students + + + + + + + + + + + + + + + + Instructors + + + + + + + + + + + + + + +
@@ -2021,13 +2028,16 @@ exports[`InstructorSessionEditPageComponent should snap with feedback session qu class="collapse-caret" > -
-
+
- - - - - - - - - - - - + - - - - - - - - - - - - - - - - - - - -
- User/Group - - Can see answer - - Can see giver's name - - Can see recipient's name -
- +
- Recipient(s) - - - - - - - - -
- + - Giver's Team Members - - - - - - - - -
- + - Other students - - - - - - - - -
- + - Instructors - - - - - - - - -
+ Can see recipient's name + + + + + + + + Recipient(s) + + + + + + + + + + + + + + + + Giver's Team Members + + + + + + + + + + + + + + + + Other students + + + + + + + + + + + + + + + + Instructors + + + + + + + + + + + + + + +
@@ -3956,13 +3970,16 @@ exports[`InstructorSessionEditPageComponent should snap with new question added class="collapse-caret" > -
-
+
- - - - - - - - - - - - + - - - - - - - - - - - - - - - - - - - - + + + + + - - - - - -
- User/Group - - Can see answer - - Can see giver's name - - Can see recipient's name -
- +
- Recipient(s) - - - - - - - - -
- + - Giver's Team Members - - - - - - - - -
- + - Recipient's Team Members - - - - - - - - -
- + - Other students - - - - - - - - -
- +
+ + Recipient(s) + + - Instructors - - - - - - - -
+ + + + + + + + + + + + + Giver's Team Members + + + + + + + + + + + + + + + + Recipient's Team Members + + + + + + + + + + + + + + + + Other students + + + + + + + + + + + + + + + + Instructors + + + + + + + + + + + + + + +
diff --git a/src/web/app/pages-instructor/instructor-session-edit-page/copy-questions-from-other-sessions-modal/__snapshots__/copy-questions-from-other-sessions-modal.component.spec.ts.snap b/src/web/app/pages-instructor/instructor-session-edit-page/copy-questions-from-other-sessions-modal/__snapshots__/copy-questions-from-other-sessions-modal.component.spec.ts.snap index 2bfa2d770dd..495af9d2180 100644 --- a/src/web/app/pages-instructor/instructor-session-edit-page/copy-questions-from-other-sessions-modal/__snapshots__/copy-questions-from-other-sessions-modal.component.spec.ts.snap +++ b/src/web/app/pages-instructor/instructor-session-edit-page/copy-questions-from-other-sessions-modal/__snapshots__/copy-questions-from-other-sessions-modal.component.spec.ts.snap @@ -80,13 +80,16 @@ exports[`CopyQuestionsFromOtherSessionsModalComponent should snap when feedback class="card-header-btn-toolbar" > -
-
+
@@ -288,13 +291,16 @@ exports[`CopyQuestionsFromOtherSessionsModalComponent should snap when feedback class="card-header-btn-toolbar" > -
-
+
@@ -420,13 +426,16 @@ exports[`CopyQuestionsFromOtherSessionsModalComponent should snap when feedback class="card-header-btn-toolbar" > -
-
+
@@ -638,13 +647,16 @@ exports[`CopyQuestionsFromOtherSessionsModalComponent should snap with feedback class="card-header-btn-toolbar" > - + @@ -668,13 +680,16 @@ exports[`CopyQuestionsFromOtherSessionsModalComponent should snap with feedback class="card-header-btn-toolbar" > - + diff --git a/src/web/app/pages-instructor/instructor-student-activity-logs/__snapshots__/instructor-student-activity-logs.component.spec.ts.snap b/src/web/app/pages-instructor/instructor-student-activity-logs/__snapshots__/instructor-student-activity-logs.component.spec.ts.snap index 8fb22eed5b3..2c2f0ec0b7e 100644 --- a/src/web/app/pages-instructor/instructor-student-activity-logs/__snapshots__/instructor-student-activity-logs.component.spec.ts.snap +++ b/src/web/app/pages-instructor/instructor-student-activity-logs/__snapshots__/instructor-student-activity-logs.component.spec.ts.snap @@ -1249,13 +1249,16 @@ exports[`InstructorStudentActivityLogsComponent should snap with results of a se class="card-header-btn-toolbar" > -
-
+
@@ -1431,13 +1434,16 @@ exports[`InstructorStudentActivityLogsComponent should snap with results of a se class="card-header-btn-toolbar" > -
-
+
diff --git a/src/web/app/pages-instructor/instructor-student-list-page/__snapshots__/instructor-student-list-page.component.spec.ts.snap b/src/web/app/pages-instructor/instructor-student-list-page/__snapshots__/instructor-student-list-page.component.spec.ts.snap index 1af0749d7cb..fbb9e7a35d7 100644 --- a/src/web/app/pages-instructor/instructor-student-list-page/__snapshots__/instructor-student-list-page.component.spec.ts.snap +++ b/src/web/app/pages-instructor/instructor-student-list-page/__snapshots__/instructor-student-list-page.component.spec.ts.snap @@ -86,13 +86,16 @@ exports[`InstructorStudentListPageComponent should snap with a course with stude class="card-header-btn-toolbar" > -
-
+
diff --git a/src/web/app/pages-session/session-result-page/session-result-page.component.spec.ts b/src/web/app/pages-session/session-result-page/session-result-page.component.spec.ts index 9cffde1612e..48c6b131a2b 100644 --- a/src/web/app/pages-session/session-result-page/session-result-page.component.spec.ts +++ b/src/web/app/pages-session/session-result-page/session-result-page.component.spec.ts @@ -391,7 +391,7 @@ describe('SessionResultPageComponent', () => { otherResponses: [], isLoading: false, isLoaded: false, - hasResponse: true, + hasResponse: false, hasResponseButNotVisibleForPreview: false, hasCommentNotVisibleForPreview: false, }; diff --git a/src/web/app/pages-session/session-result-page/session-result-page.component.ts b/src/web/app/pages-session/session-result-page/session-result-page.component.ts index 4ad7fd4566b..9dcbeb6563a 100644 --- a/src/web/app/pages-session/session-result-page/session-result-page.component.ts +++ b/src/web/app/pages-session/session-result-page/session-result-page.component.ts @@ -327,7 +327,7 @@ export class SessionResultPageComponent implements OnInit { otherResponses: [], isLoading: false, isLoaded: false, - hasResponse: true, + hasResponse: false, hasResponseButNotVisibleForPreview: false, hasCommentNotVisibleForPreview: false, }); diff --git a/src/web/app/pages-session/session-submission-page/__snapshots__/session-submission-page.component.spec.ts.snap b/src/web/app/pages-session/session-submission-page/__snapshots__/session-submission-page.component.spec.ts.snap index 5c5e4ac3433..c298b13ebfe 100644 --- a/src/web/app/pages-session/session-submission-page/__snapshots__/session-submission-page.component.spec.ts.snap +++ b/src/web/app/pages-session/session-submission-page/__snapshots__/session-submission-page.component.spec.ts.snap @@ -891,23 +891,23 @@ exports[`SessionSubmissionPageComponent should snap with feedback session questi class="card" id="question-submission-form-qn-1" > - question brief - +
-
+ question brief - +
-
+

question brief

- +
-
+ MSQ question - +
-
+ numerical scale question - +
-
+ constant sum question - +
-
+ contribution question - +
-
+ question brief - +
-
+ question brief - +
-
+ question brief - +
-
+ question brief - +
-
+ question brief - +
-
+

question brief

- +
-
+ MSQ question - +
-
+ numerical scale question - +
-
+ constant sum question - +
-
+ contribution question - +
-
+ question brief - +
-
+ question brief - +
-
+ question brief - +