From 0e09533390c86797ab45aa6800162d9910145aa8 Mon Sep 17 00:00:00 2001
From: Luca Zanetti <90850610+Mex7180@users.noreply.github.com>
Date: Wed, 13 Sep 2023 05:14:15 +0200
Subject: [PATCH 1/2] [#12314] Popover appears in front of modal blocking
 buttons (#12573)

* Add mouseenter event and close tooltip if button is clicked

* Remove added code from session-submission-page

* Update question-submission-form.component.html

Co-authored-by: Jason Qiu <jason_qiu@hotmail.com>

---------

Co-authored-by: Jason Qiu <jason_qiu@hotmail.com>
---
 .../question-submission-form.component.html                    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/web/app/components/question-submission-form/question-submission-form.component.html b/src/web/app/components/question-submission-form/question-submission-form.component.html
index 069c63a0899..5f964b5cb39 100644
--- a/src/web/app/components/question-submission-form/question-submission-form.component.html
+++ b/src/web/app/components/question-submission-form/question-submission-form.component.html
@@ -214,7 +214,8 @@ <h2 class="question-details"><b>Question {{ model.questionNumber }}: </b>{{ mode
         <div class="col-12 text-center">
           <button id="btn-submit-qn-{{ model.questionNumber }}" type="submit" class="btn btn-success"
                   ngbTooltip="You can save your responses for this question at any time and come back later to continue."
-                  (click)="saveFeedbackResponses()" [disabled]="isSavingResponses || isSubmissionDisabled">
+                  #tooltip="ngbTooltip" (mouseenter)="tooltip.open()"
+                  (click)="saveFeedbackResponses(); tooltip.close();"[disabled]="isSavingResponses || isSubmissionDisabled">
             <tm-ajax-loading *ngIf="isSavingResponses"></tm-ajax-loading>
             <span>{{ isQuestionCountOne ? "Submit Response" : "Submit Response for Question " + model.questionNumber }}</span>
           </button>

From ed3d5f0ea97c93bb68878651670a36841cf67ebd Mon Sep 17 00:00:00 2001
From: Bryan Lejkowski <83157275+blejkowski@users.noreply.github.com>
Date: Thu, 14 Sep 2023 21:40:43 -0400
Subject: [PATCH 2/2] [#12499] Flickering questions when loading session
 results (#12570)

* [#12499] Fixed flickering questions when loading feedback session results.

* Update question-response-panel.component.ts

* Update question-response-panel.component.ts

* Update question-response-panel.component.ts

* Update session-result-page.component.spec.ts

* Update question-response-panel.component.ts

* Update question-response-panel.component.ts

* Update question-response-panel.component.ts

---------

Co-authored-by: Jason Qiu <jason_qiu@hotmail.com>
---
 .../question-response-panel.component.ts                       | 3 ++-
 .../session-result-page/session-result-page.component.spec.ts  | 2 +-
 .../session-result-page/session-result-page.component.ts       | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/web/app/components/question-response-panel/question-response-panel.component.ts b/src/web/app/components/question-response-panel/question-response-panel.component.ts
index e1b3a9d6e4c..e44f8a56f55 100644
--- a/src/web/app/components/question-response-panel/question-response-panel.component.ts
+++ b/src/web/app/components/question-response-panel/question-response-panel.component.ts
@@ -96,6 +96,7 @@ export class QuestionResponsePanelComponent {
       next: (sessionResults: SessionResults) => {
         const responses: QuestionOutput = sessionResults.questions[0];
         if (responses) {
+          question.hasResponse = true;
           question.feedbackQuestion = responses.feedbackQuestion;
           question.allResponses = responses.allResponses;
           question.otherResponses = responses.otherResponses;
@@ -104,7 +105,7 @@ export class QuestionResponsePanelComponent {
           question.responsesToSelf = responses.responsesToSelf;
           question.hasResponseButNotVisibleForPreview = responses.hasResponseButNotVisibleForPreview;
           question.hasCommentNotVisibleForPreview = responses.hasCommentNotVisibleForPreview;
-        } else {
+      } else {
           question.hasResponse = false;
           if (question.errorMessage) {
             this.statusMessageService.showSuccessToast('Question '
diff --git a/src/web/app/pages-session/session-result-page/session-result-page.component.spec.ts b/src/web/app/pages-session/session-result-page/session-result-page.component.spec.ts
index 9cffde1612e..48c6b131a2b 100644
--- a/src/web/app/pages-session/session-result-page/session-result-page.component.spec.ts
+++ b/src/web/app/pages-session/session-result-page/session-result-page.component.spec.ts
@@ -391,7 +391,7 @@ describe('SessionResultPageComponent', () => {
       otherResponses: [],
       isLoading: false,
       isLoaded: false,
-      hasResponse: true,
+      hasResponse: false,
       hasResponseButNotVisibleForPreview: false,
       hasCommentNotVisibleForPreview: false,
     };
diff --git a/src/web/app/pages-session/session-result-page/session-result-page.component.ts b/src/web/app/pages-session/session-result-page/session-result-page.component.ts
index 4ad7fd4566b..9dcbeb6563a 100644
--- a/src/web/app/pages-session/session-result-page/session-result-page.component.ts
+++ b/src/web/app/pages-session/session-result-page/session-result-page.component.ts
@@ -327,7 +327,7 @@ export class SessionResultPageComponent implements OnInit {
                     otherResponses: [],
                     isLoading: false,
                     isLoaded: false,
-                    hasResponse: true,
+                    hasResponse: false,
                     hasResponseButNotVisibleForPreview: false,
                     hasCommentNotVisibleForPreview: false,
                   });