master vs dev branches #14
Comments
|
Please use the preview to check the formatting - that error is really hard to read. I think maybe you're not on the current dev branch. Note this line in the error: But when I look at the dev branch line 104, I don't see that line at all: https://github.com/TD22057/insteon-mqtt/blob/dev/insteon_mqtt/handler/DeviceDbGet.py#L104 So my guess is that you somehow have a mix of the dev/main or caught a revision of the dev branch that wasn't working. Try updating ( |
|
@mwdng You can also use: |
|
@TD22057 & @larizzo Thanx for the direction I just created a new env and did a git clone only for the dev branch. After a little work on the config file, I am at least in the right place for now we will see how it goes when it is time to pull updates again. BTW: Is there another place to post just general comments and discussions (on this project) or is everything at this point going here? @larizzo the only thing I did different was I didn't do the "--single-branch" is it required? I did get only the dev branch. Just don't something else to bit me in the but later. |
|
Ok, back where I started. Below is an error that I get doing the same operation two different ways. I think that they are related but not sure. Please take a look and let me know what you think. it seems to happen with different commands but I thought I would look at them one at a time. `command line entry: (dev_env) michael@ubuntu-dev:~/insteon-mqtt$ insteon-mqtt refresh config.yaml 0d.77.2c returned from above command: Commanding Dimmer device 0d.77.2c hall_2 cmd=refresh Results: (config.yaml log set to "10") 2017-12-19 13:14:12 INFO Mqtt: MQTT message insteon/command/0d.77.2c b'{"cmd": "refresh", "force": false, "session": "2968331454"}' I think it is related to the same issue but it shows up a little differently: From mqtt: Note: I also tried changing the force flag to true and still got the same issue. Results: 2017-12-19 13:21:17 INFO Mqtt: MQTT message insteon/command/0d.77.2c b'{\n"cmd" : "refresh", \n"force" : false\n}' Michael |
|
Something is still weird in your branch, or in the install, or how it's being run. One problem is that the output mqtt command you showed is wrong. When the cmd line tools sends a command, there is a session ID sent which allows the reply to work properly. When I use the dev branch and send a refresh command, the MQTT packet sequence is this: From the first example, that looks like it works. Not sure why there is no session key in the second one - I don't see how that's possible. I pushed a change to dev to fix the exception you saw, but it should have never reached there in the first place. As for the time out - I don't have any idea about that one. Obviously the device is available - it got the level just fine in the reply. But when it sent the command to download the db, it got no response. That command works fine for every device that I own. Do you have the model number of the device? |
|
Ok, here is what I know for now. since the last adjustment the errors are more similar. So I have went through all the devices (still have more to add to insteon-mqtt later) I found issues with 2 of them, one is a keypadlinc 2486D V1.8 and one is a dimmer 2476D V3.3. they both still give me errors when I attempt to refresh them from the cmd line (insteon-mqtt refresh -f config.yaml aa.bb.cc ). I have quite a few older insteon units (no X10) mixed in from the last 10 yrs or so. Really not sure what I will find as I keep adding them. dimmer Issue from above: ` insteon/command/14.37.2b This is what I get back: Michael |
|
That probably explains it.
|
|
Ok.(1) Cool at least now I know why and what to expect (2) For now it's not a problem, it's just others with older devices will have to know so they don't get bogged down chasing it. Everything still works within Home assistant where I use it (experimenting with Node Red) so its not a show stopper. As far as forking the project I am not sure that I am ready for that just yet. Not really a python developer but this would definitely be a challenge and who doesn't need a challenge. So if I head that way I might need a little help w development tools to start with. So for now I will continue testing against my setup. |
|
FYI it looks like device 14.37.2b did respond to the refresh command in the example above. I've added issue #17 to explicitly support older devices. If it's ok with you, I'll close this one out (feel free to keep asking questions here if you want). |
I can't really call this an issue because I am having a impossible time working from the "dev" branch and I know that it was requested to only send issues with that branch since it is being fixed and repaired as we go.
Here is an error I am getting:
2017-12-17 19:10:17 ERROR Serial: Serial read error from /dev/ttyUSB0 Traceback (most recent call last): File "/home/michael/insteon-mqtt/venv/lib/python3.5/site-packages/insteon_mqtt/network/Serial.py", line 174, in read_from_link self.signal_read.emit(self, data) File "/home/michael/insteon-mqtt/venv/lib/python3.5/site-packages/insteon_mqtt/Signal.py", line 50, in emit slot(*args, **kwargs) File "/home/michael/insteon-mqtt/venv/lib/python3.5/site-packages/insteon_mqtt/Protocol.py", line 255, in _data_read self._process_msg(msg) File "/home/michael/insteon-mqtt/venv/lib/python3.5/site-packages/insteon_mqtt/Protocol.py", line 277, in _process_msg status = self._write_handler.msg_received(self, msg) File "/home/michael/insteon-mqtt/venv/lib/python3.5/site-packages/insteon_mqtt/handler/DeviceDbGet.py", line 104, in msg_received self.on_done(True, "Database received") File "/home/michael/insteon-mqtt/venv/lib/python3.5/site-packages/insteon_mqtt/handler/DeviceRefresh.py", line 123, in on_done self.device.db.set_delta(msg.cmd1) AttributeError: 'str' object has no attribute 'cmd1' 2017-12-17 19:10:23 WARNING Protocol: Last message timed outI can get more details but I would really like some help getting the "dev" branch working. I used the "quick start" guide as a starting point with the master branch a few weeks back, but no matter what I seem to do the only code that will run is the master branch. I am more than sure it's me. Any help would be greatly appreciated.
Michael
The text was updated successfully, but these errors were encountered: