Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deterministic ordering for verb metadata #3429

Merged

Conversation

worstell
Copy link
Contributor

inject in the correct position, but display metadata in a deterministic order in the schema. if param orderings change, schema will remain consistent

@worstell worstell requested review from a team and alecthomas as code owners November 19, 2024 18:45
This was referenced Nov 19, 2024
@worstell worstell force-pushed the worstell/20241119-deterministic-order-for-verb-resources branch 2 times, most recently from 8ece1ff to cb26fc3 Compare November 19, 2024 19:41
inject in the correct position, but display metadata in a deterministic order in the schema. if param orderings change, schema will remain consistent
@worstell worstell force-pushed the worstell/20241119-deterministic-order-for-verb-resources branch from 10b9386 to 366f26b Compare November 19, 2024 20:58
@stuartwdouglas
Copy link
Collaborator

I wonder if this should actually go into some kinda of schema normalization handler on the server? This would mean that all runtimes get the same normalization rules and it does not have to be implemented for each language.

@worstell
Copy link
Contributor Author

I wonder if this should actually go into some kinda of schema normalization handler on the server? This would mean that all runtimes get the same normalization rules and it does not have to be implemented for each language.

this will actually apply across runtimes already, schema.ValidateSchema gets called when we deserialize schema from proto

@worstell worstell merged commit 4a40b63 into main Nov 19, 2024
91 checks passed
@worstell worstell deleted the worstell/20241119-deterministic-order-for-verb-resources branch November 19, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants