refactor: pull out SchemaService methods from Controller #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
force-pushed
the
aat/schema-service-extract
branch
from
f4d9e3b
to
a8feafd
Compare
alecthomas
added
the
skip-proto-breaking
alecthomas
force-pushed
the
aat/schema-service-extract
branch
from
a8feafd
to
e831a59
Compare
alecthomas
force-pushed
the
aat/schema-service-extract
branch
from
e831a59
to
ec5da11
Compare
alecthomas
requested review from
stuartwdouglas,
worstell and
wesbillman
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.